linux-kernel - Re: [PATCH 1/2] ARM: dts: broadcom: bcm2835-rpi: Move the firmware node down 1 level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9a202c1-048f-473e-b8f4-6f0550bdba2c@broadcom.com>
Date: Wed, 14 Jan 2026 10:22:27 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: broadcom: bcm2835-rpi: Move the firmware
 node down 1 level



On 1/13/2026 5:58 PM, Rob Herring (Arm) wrote:
> Commit 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non
> simple-bus nodes to root level") moved the firmware nodes into the
> standard /firmware. However, /firmware is intended to be just a
> container for firmware nodes as it is possible to have multiple types of
> firmware (e.g. SCMI, OP-TEE, etc.). Move the RPi firmware down a level.
> 
> Fixes: 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non simple-bus nodes to root level")
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> This is only half the fix. Unfortunately, a kernel change[1] is also
> needed to make this all work. I do plan for that to go to stable. I'll
> leave it up to the Broadcom maintainers whether it's preferred to revert
> the fixed patches or apply these fixes. A 3rd option is revert for now
> and apply these DT changes some time later to give some time for stable
> updates.

Let's wait until your fix for the /firmware match table gets applied and 
then I will pick up your two changes.
-- 
Florian