linux-kernel - Re: [PATCH v3 04/15] rust: pin-init: internal: add utility API for syn error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFOIVDERL2IO.1UMVC46XAKVPC@garyguo.net>
Date: Wed, 14 Jan 2026 18:26:43 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Benno Lossin" <lossin@...nel.org>, "Gary Guo" <gary@...yguo.net>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>,
 "Fiona Behrens" <me@...enk.dev>
Cc: <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v3 04/15] rust: pin-init: internal: add utility API for
 syn error handling

On Wed Jan 14, 2026 at 6:18 PM GMT, Benno Lossin wrote:
> The API is similar to diagnostics handling in rustc and uses a
> `ErrorGuaranteed` value to signify that an error has been emitted. It
> supports both fatal errors (which abort the macro expansion immediately
> by returning `Err(ErrorGuaranteed)`) and non-fatal ones at at generation
> time. These errors are appended to the token stream after generation has
> finished normally. This allows giving good errors while still expanding
> most of the code as expected to avoid the user encountering additional
> errors (for example missing definitions).
> 
> Suggested-by: Gary Guo <gary@...yguo.net>
> Tested-by: Andreas Hindborg <a.hindborg@...nel.org>
> Signed-off-by: Benno Lossin <lossin@...nel.org>

Reviewed-by: Gary Guo <gary@...yguo.net>

> ---
> Changes in v3: switch to Gary's suggestion
> Changes in v2: added this patch
> ---
>  rust/pin-init/internal/src/diagnostics.rs | 32 +++++++++++++++++++++++
>  rust/pin-init/internal/src/lib.rs         |  1 +
>  2 files changed, 33 insertions(+)
>  create mode 100644 rust/pin-init/internal/src/diagnostics.rs