linux-kernel - Re: [PATCH 1/1] mshv: Store the result of vfs_poll in a variable of type __poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49fd5523-f558-4ac0-b1a5-d0ead75bd9f3@linux.microsoft.com>
Date: Wed, 14 Jan 2026 10:40:04 -0800
From: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To: mhklinux@...look.com, kys@...rosoft.com, haiyangz@...rosoft.com,
 wei.liu@...nel.org, decui@...rosoft.com, longli@...rosoft.com,
 linux-hyperv@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mshv: Store the result of vfs_poll in a variable of
 type __poll_t

On 1/14/2026 9:01 AM, mhkelley58@...il.com wrote:
> From: Michael Kelley <mhklinux@...look.com>
> 
> vfs_poll() returns a result of type __poll_t, but current code is using
> an "unsigned int" local variable. The difference is that __poll_t carries
> the "bitwise" attribute. This attribute is not interpreted by the C
> compiler; it is only used by 'sparse' to flag incorrect usage of the
> return value. The return value is used correctly here, so there's no
> bug, but sparse complains about the type mismatch.
> 
> In the interest of general correctness and to avoid noise from sparse,
> change the local variable to type __poll_t. No functional change.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512141339.791TCKnB-lkp@intel.com/
> Signed-off-by: Michael Kelley <mhklinux@...look.com>
> ---
> This change is not marked with a Fixes: tag as there's no value in
> backporting to older stable releases.
> 
>  drivers/hv/mshv_eventfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/mshv_eventfd.c b/drivers/hv/mshv_eventfd.c
> index d93a18f09c76..0b75ff1edb73 100644
> --- a/drivers/hv/mshv_eventfd.c
> +++ b/drivers/hv/mshv_eventfd.c
> @@ -388,7 +388,7 @@ static int mshv_irqfd_assign(struct mshv_partition *pt,
>  {
>  	struct eventfd_ctx *eventfd = NULL, *resamplefd = NULL;
>  	struct mshv_irqfd *irqfd, *tmp;
> -	unsigned int events;
> +	__poll_t events;
>  	int ret;
>  	int idx;
>  

Reviewed-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>