linux-kernel - Re: [PATCH v2 3/3] vfio: selftests: Add vfio_dma_mapping_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWfkPeUMPlIMX7o2@devgpu015.cco6.facebook.com>
Date: Wed, 14 Jan 2026 10:45:17 -0800
From: Alex Mastro <amastro@...com>
To: David Matlack <dmatlack@...gle.com>
CC: Alex Williamson <alex@...zbot.org>, Shuah Khan <shuah@...nel.org>,
        Peter
 Xu <peterx@...hat.com>, <linux-kernel@...r.kernel.org>,
        <kvm@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        Jason Gunthorpe
	<jgg@...pe.ca>
Subject: Re: [PATCH v2 3/3] vfio: selftests: Add vfio_dma_mapping_mmio_test

On Wed, Jan 14, 2026 at 05:52:15PM +0000, David Matlack wrote:
> On 2026-01-13 03:08 PM, Alex Mastro wrote:
> 
> > +FIXTURE_SETUP(vfio_dma_mapping_mmio_test)
> > +{
> > +	self->iommu = iommu_init(variant->iommu_mode);
> > +	self->device = vfio_pci_device_init(device_bdf, self->iommu);
> > +	self->iova_allocator = iova_allocator_init(self->iommu);
> > +	self->bar = largest_mapped_bar(self->device);
> > +
> > +	if (!self->bar)
> > +		SKIP(return, "No mappable BAR found on device %s", device_bdf);
> > +
> > +	if (self->bar->info.size < 2 * getpagesize())
> > +		SKIP(return, "BAR too small (size=0x%llx)", self->bar->info.size);
> 
> It seems like the selftest should only skip map_partial_bar if the BAR
> is less than 2 pages. map_full_bar would still be a valid test to run.

True. This was me being lax.