linux-kernel - Re: [PATCH v3 2/7] rust: io: always inline functions using build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14af917dab28321a69b81765d81d33aa4616bce5.camel@nvidia.com>
Date: Wed, 14 Jan 2026 19:26:41 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "lossin@...nel.org" <lossin@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "viresh.kumar@...aro.org"
	<viresh.kumar@...aro.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "tmgross@...ch.edu"
	<tmgross@...ch.edu>, "daniel.almeida@...labora.com"
	<daniel.almeida@...labora.com>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "will@...nel.org" <will@...nel.org>,
	"mark.rutland@....com" <mark.rutland@....com>, "peterz@...radead.org"
	<peterz@...radead.org>, "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"rafael@...nel.org" <rafael@...nel.org>, "gary@...yguo.net"
	<gary@...yguo.net>, "dakr@...nel.org" <dakr@...nel.org>
CC: "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v3 2/7] rust: io: always inline functions using
 build_assert with arguments

On Mon, 2025-12-08 at 11:47 +0900, Alexandre Courbot wrote:
> `build_assert` relies on the compiler to optimize out its error path.
> Functions using it with its arguments must thus always be inlined,
> otherwise the error path of `build_assert` might not be optimized out,
> triggering a build error.
> 
> Cc: stable@...r.kernel.org
> Fixes: ce30d94e6855 ("rust: add `io::{Io, IoRaw}` base types")
> Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>

Tested-by: Timur Tabi <ttabi@...dia.com>

Without patch 2/7, my Turing patchset will fail to compile with CLIPPY.  So please merge this
patchset, or at least just this patch, soon.