linux-kernel - Re: [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <lpocmy3nmdcudoewe6uxal4srnd2acvb4fi73fthbruyb3wpo6@ky5cpwirm2vm>
Date: Wed, 14 Jan 2026 14:37:51 -0600
From: Andrew Jones <andrew.jones@....qualcomm.com>
To: joaopeixoto@...x.tech
Cc: linux-kernel@...r.kernel.org, ajd@...ux.ibm.com, alex@...ti.fr,
        aou@...s.berkeley.edu, bagasdotme@...il.com, catalin.marinas@....com,
        conor+dt@...nel.org, corbet@....net, dan.j.williams@...el.com,
        davidmcerdeira@...x.tech, devicetree@...r.kernel.org, dev@...l-k.io,
        gregkh@...uxfoundation.org, haren@...ux.ibm.com, heiko@...ech.de,
        jose@...x.tech, kever.yang@...k-chips.com, krzk+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
        linux-riscv@...ts.infradead.org, maddy@...ux.ibm.com, mani@...nel.org,
        nathan@...nel.org, neil.armstrong@...aro.org, palmer@...belt.com,
        pjw@...nel.org, prabhakar.mahadev-lad.rj@...renesas.com,
        robh@...nel.org, will@...nel.org
Subject: Re: [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver

On Wed, Jan 07, 2026 at 04:28:25PM +0000, joaopeixoto@...x.tech wrote:
...
> diff --git a/arch/riscv/include/asm/bao.h b/arch/riscv/include/asm/bao.h
> new file mode 100644
> index 000000000000..35658f37e1bd
> --- /dev/null
> +++ b/arch/riscv/include/asm/bao.h
> @@ -0,0 +1,31 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Bao Hypervisor Hypercall Interface
> + *
> + * Copyright (c) Bao Project and Contributors. All rights reserved.
> + *
> + * Authors:
> + *	João Peixoto <joaopeixoto@...x.tech>
> + *	José Martins <jose@...x.tech>
> + *	David Cerdeira <davidmcerdeira@...x.tech>
> + */
> +
> +#ifndef __ASM_RISCV_BAO_H
> +#define __ASM_RISCV_BAO_H
> +
> +#include <asm/sbi.h>
> +
> +#define BAO_SBI_EXT_ID 0x08000ba0
> +
> +static inline unsigned long bao_ipcshmem_hypercall(unsigned long hypercall_id,
> +						   unsigned long ipcshmem_id)
> +{
> +	struct sbiret ret;
> +
> +	ret = sbi_ecall(BAO_SBI_EXT_ID, hypercall_id, ipcshmem_id, 0, 0, 0, 0,
> +			0);

Just let lines like these stick out. We have up to 100 chars and these
types of few-char wraps are the most annoying.

Thanks,
drew