linux-kernel - Re: [PATCH v2 1/1] x86/rdrand: disable RDSEED on AMD Cyan Skillfish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHSgyMNLDC3ooMdsRj1ri-BFSYhC0DPjsvFzT_kdLK1OQPqEFQ@mail.gmail.com>
Date: Wed, 14 Jan 2026 15:52:16 -0500
From: Travis B <tbangs89@...il.com>
To: me@...aill.net
Cc: bp@...en8.de, dave.hansen@...ux.intel.com, linux-kernel@...r.kernel.org, 
	mario.limonciello@....com, mingo@...hat.com, tglx@...utronix.de, 
	x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/rdrand: disable RDSEED on AMD Cyan Skillfish

Hello, I realize this is now post-merge but I have feedback:

> pr_emerg("RDSEED is not reliable on this platform; disabling.\n");

I think that pr_emerg is an inappropriate message level
for the RDSEED disable notices; it is not a system-halting error
by any means and is expected on this hardware.

These should be pr_notice_once instead.
(the message is also shown dozens of times in a row currently)

Currently users of BC-250 have no way of disabling the RDSEED
disabled notice messages on startup without hiding all other
real error messages due to it currently logging at EMERGENCY
level.

It is probably a good idea to do this in the Zen5 version
of the RDSEED disabling as well.