linux-kernel - Re: [tip:timers/vdso 12/14] net/rds/ib_cm.c:96:35: sparse: sparse: incorrect type in argument 1 (different modifiers)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVGnY37bCOUHx_tCgQ=K55CcSOzs98Hg2Mh7KF4Mbya+g@mail.gmail.com>
Date: Wed, 14 Jan 2026 13:03:31 -0800
From: Ian Rogers <irogers@...gle.com>
To: Thomas Gleixner <tglx@...nel.org>
Cc: kernel test robot <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [tip:timers/vdso 12/14] net/rds/ib_cm.c:96:35: sparse: sparse:
 incorrect type in argument 1 (different modifiers)

On Wed, Jan 14, 2026 at 12:04 PM Thomas Gleixner <tglx@...nel.org> wrote:
>
> On Wed, Jan 14 2026 at 09:51, Ian Rogers wrote:
> > On Wed, Jan 14, 2026 at 8:37 AM kernel test robot <lkp@...el.com> wrote:
> > I think there are 2 options:
> > 1) ignore the new sparse warning as tech debt for later clean up,
> > 2) modify the cast to be "const void*" instead of "void *" and play
> > more wac-a-mole.
>
> Option #3:
>
> You might have tried the 'const void*' cast and figured out that sparse
> is still unhappy. I actually did, but I didn't try to figure out why as
> that's really not my duty.
>
> > My preference would be 1 as I have a suspicion I played 2 and thought
> > the non-const cast was best (hence it being in the patch) given other
> > issues.
>
> Preferences based on suspicions are not really usefull. Please go and
> figure out what's going on and either fix it in the kernel code or tell
> the sparse folks what they are missing.
>
> Leaving it unresolved and handwaved away is not an option.

I'd like to call this option, play a bunch of wac-a-mole but then
still don't really progress. I had tried out I believe all the options
6 months ago where the builds were clean. There's always 1 more tool
that's going to raise its head and complain about types, my motivation
remains clang and gcc for user space copies of this code so we don't
need to propagate -fno-strict-aliasing into places like perf. Tbh, I'm
not going to be able to look at this for a while so I'd suggest just
dropping the patches.

Thanks,
Ian

> Thanks,
>
>         tglx