linux-kernel - Re: [PATCH v14 18/34] cxl/port: Remove "enumerate dports" helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0f6d666-cd79-42a2-ace3-41460a199fb3@intel.com>
Date: Wed, 14 Jan 2026 14:23:17 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>,
 Terry Bowman <terry.bowman@....com>
Cc: dave@...olabs.net, alison.schofield@...el.com, dan.j.williams@...el.com,
 bhelgaas@...gle.com, shiju.jose@...wei.com, ming.li@...omail.com,
 Smita.KoralahalliChannabasappa@....com, rrichter@....com,
 dan.carpenter@...aro.org, PradeepVineshReddy.Kodamati@....com,
 lukas@...ner.de, Benjamin.Cheatham@....com,
 sathyanarayanan.kuppuswamy@...ux.intel.com, linux-cxl@...r.kernel.org,
 vishal.l.verma@...el.com, alucerop@....com, ira.weiny@...el.com,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v14 18/34] cxl/port: Remove "enumerate dports" helpers



On 1/14/26 12:50 PM, Jonathan Cameron wrote:
> On Wed, 14 Jan 2026 12:20:39 -0600
> Terry Bowman <terry.bowman@....com> wrote:
> 
>> From: Dan Williams <dan.j.williams@...el.com>
>>
>> Now that cxl_switch_port_probe() no longer walks potential dports, because
>> they are enumerated dynamically on descendant endpoint arrival, remove the
>> dead code.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>> Reviewed-by: Terry Bowman <terry.bowman@....com>
> 
> Patch description doesn't match patch. 

Looks like it's the clean up of this commit that's upstream.
Fixes: 3f5b8f7f34f6 ("cxl/port: Remove devm_cxl_port_enumerate_dports()")

> 
>>
>> ---
>>
>> Changes in v13 -> v14:
>> - New patch
>> ---
>>  drivers/cxl/core/pci.c | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
>> index b838c59d7a3c..0305a421504e 100644
>> --- a/drivers/cxl/core/pci.c
>> +++ b/drivers/cxl/core/pci.c
>> @@ -71,6 +71,14 @@ struct cxl_dport *__devm_cxl_add_dport_by_dev(struct cxl_port *port,
>>  }
>>  EXPORT_SYMBOL_NS_GPL(__devm_cxl_add_dport_by_dev, "CXL");
>>  
>> +struct cxl_walk_context {
>> +	struct pci_bus *bus;
>> +	struct cxl_port *port;
>> +	int type;
>> +	int error;
>> +	int count;
>> +};
>> +
>>  static int cxl_dvsec_mem_range_valid(struct cxl_dev_state *cxlds, int id)
>>  {
>>  	struct pci_dev *pdev = to_pci_dev(cxlds->dev);
>> @@ -820,14 +828,6 @@ int cxl_gpf_port_setup(struct cxl_dport *dport)
>>  	return 0;
>>  }
>>  
>> -struct cxl_walk_context {
>> -	struct pci_bus *bus;
>> -	struct cxl_port *port;
>> -	int type;
>> -	int error;
>> -	int count;
>> -};
>> -
>>  static int count_dports(struct pci_dev *pdev, void *data)
>>  {
>>  	struct cxl_walk_context *ctx = data;
>