linux-kernel - [PATCH 3/3] ovl: Use real disk UUID for origin file handles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260114-tonyk-get_disk_uuid-v1-3-e6a319e25d57@igalia.com>
Date: Wed, 14 Jan 2026 01:31:43 -0300
From: André Almeida <andrealmeid@...lia.com>
To: Christoph Hellwig <hch@....de>, Chuck Lever <chuck.lever@...cle.com>, 
 Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>, 
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, 
 Tom Talpey <tom@...pey.com>, Carlos Maiolino <cem@...nel.org>, 
 Amir Goldstein <amir73il@...il.com>, Chris Mason <clm@...com>, 
 David Sterba <dsterba@...e.com>, Miklos Szeredi <miklos@...redi.hu>, 
 Christian Brauner <brauner@...nel.org>, 
 Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
 linux-btrfs@...r.kernel.org, linux-unionfs@...r.kernel.org, 
 kernel-dev@...lia.com, 
 André Almeida <andrealmeid@...lia.com>
Subject: [PATCH 3/3] ovl: Use real disk UUID for origin file handles

Some filesystem, like btrfs, supports mounting cloned images, but assign
random UUIDs for them to avoid conflicts. This breaks overlayfs "index"
check, given that every time the same image is mounted, it get's
assigned a new UUID.

Fix this assigning the disk UUID for filesystem that implements the
export operation get_disk_uuid(), so overlayfs check is also against the
same value.

Signed-off-by: André Almeida <andrealmeid@...lia.com>
---
 fs/overlayfs/copy_up.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 758611ee4475..8551681fffd3 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -421,8 +421,26 @@ struct ovl_fh *ovl_encode_real_fh(struct ovl_fs *ofs, struct inode *realinode,
 	struct ovl_fh *fh;
 	int fh_type, dwords;
 	int buflen = MAX_HANDLE_SZ;
-	uuid_t *uuid = &realinode->i_sb->s_uuid;
-	int err;
+	struct super_block *real_sb = realinode->i_sb;
+	uuid_t *uuid = &real_sb->s_uuid, real_uuid;
+	u32 len = sizeof(uuid_t);
+	int err, ret;
+	u64 offset;
+
+	/*
+	 * Some filesystems that support cloned devices may expose random UUIDs
+	 * for userspace, which will cause the upper root origin check to fail
+	 * during a remount. To avoid this, store the real disk UUID.
+	 *
+	 * ENODATA means that the filesystem implements get_disk_uuid(), but
+	 * this instance is using the real UUID so we can skip the operation.
+	 */
+	if (real_sb->s_export_op && real_sb->s_export_op->get_disk_uuid) {
+		ret = real_sb->s_export_op->get_disk_uuid(real_sb, real_uuid.b, &len, &offset);
+
+		if (!ret || ret != ENODATA)
+			uuid = &real_uuid;
+	}
 
 	/* Make sure the real fid stays 32bit aligned */
 	BUILD_BUG_ON(OVL_FH_FID_OFFSET % 4);

-- 
2.52.0