linux-kernel - Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114162946.4c81298e@canb.auug.org.au>
Date: Wed, 14 Jan 2026 16:29:46 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Ian Rogers <irogers@...gle.com>, Joe Perches <joe@...ches.com>, Kuan-Wei
 Chiu <visitorckw@...il.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas
 Bulwahn <lukas.bulwahn@...il.com>, Andy Whitcroft <apw@...onical.com>,
 linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an
 accidental patch separator

Hi Andrew,

On Tue, 13 Jan 2026 19:33:19 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> git is wrong.  I say so coz I invented the --- convention. 
> submitting-patches.rst says
> 
> 	  - A marker line containing simply ``---``.
> 
> The astonishingly old https://www.ozlabs.org/~akpm/stuff/tpp.txt says
> "...  scripts will treat a ^--- string as ...".  I regret not
> explicitly using "^---$".
> 
> I'd like checkpatch to emit a warning in this case.  If a line starts
> with --- then please let's warn the user that downstream tooling will
> screw this up.  

https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter

I have used dash-dash-space for as long as I can remember (which varies
these days ;-) ).

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped