linux-kernel - Re: [PATCH] drm/bridge: Separate of_drm_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFO4V0UA4HLC.3FUCX0L1QX90W@bootlin.com>
Date: Wed, 14 Jan 2026 08:28:01 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Bagas Sanjaya" <bagasdotme@...il.com>, "Linux Kernel Mailing List"
 <linux-kernel@...r.kernel.org>, "Linux DRI Development"
 <dri-devel@...ts.freedesktop.org>
Cc: "Andrzej Hajda" <andrzej.hajda@...el.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>, "Laurent
 Pinchart" <Laurent.pinchart@...asonboard.com>, "Jonas Karlman"
 <jonas@...boo.se>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Stephen
 Rothwell" <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm/bridge: Separate of_drm_find_bridge() preconditions
 list

Hello Bagas,

On Wed Jan 14, 2026 at 12:56 AM CET, Bagas Sanjaya wrote:
> Sphinx reports htmldocs warnings:
>
> Documentation/gpu/drm-kms-helpers:197: drivers/gpu/drm/drm_bridge.c:1521: ERROR: Unexpected indentation. [docutils]
> Documentation/gpu/drm-kms-helpers:197: drivers/gpu/drm/drm_bridge.c:1523: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
>
> Fix them by separating preconditions list in of_drm_find_bridge()
> kernel-doc comment from previous paragraph.
>
> Fixes: 9da0e06abda87b ("drm/bridge: deprecate of_drm_find_bridge()")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20260105155735.3b4012b6@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Thanks for your patch.

However the issue had been previously reported on Dec 30 [0] and I had sent
a fix the next day [1], but without any feedback so I couldn't apply it to
drm-misc-next.

My patch is slightly different from yours. I'm OK with either version.

[0] https://lore.kernel.org/oe-kbuild-all/202512302319.1PGGt3CN-lkp@intel.com/
[1] https://lore.kernel.org/lkml/20251231-drm-bridge-alloc-getput-drm_of_find_bridge-kdoc-fix-v1-1-193a03f0609c@bootlin.com/

Best regards,
Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com