linux-kernel - Re: [PATCH v5 2/3] mfd: simple-mfd-i2c: add default value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFO54J7CRS8U.1D9XZAJHF57HM@linux.spacemit.com>
Date: Wed, 14 Jan 2026 15:40:26 +0800
From: "Troy Mitchell" <troy.mitchell@...ux.spacemit.com>
To: "Lee Jones" <lee@...nel.org>, "Troy Mitchell"
 <troy.mitchell@...ux.spacemit.com>
Cc: "Yixun Lan" <dlan@...too.org>, "Alex Elder" <elder@...cstar.com>, "Andi
 Shyti" <andi.shyti@...nel.org>, "Alexandre Belloni"
 <alexandre.belloni@...tlin.com>, "Liam Girdwood" <lgirdwood@...il.com>,
 "Mark Brown" <broonie@...nel.org>, <linux-kernel@...r.kernel.org>,
 <linux-riscv@...ts.infradead.org>, <spacemit@...ts.linux.dev>,
 <linux-i2c@...r.kernel.org>, <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH v5 2/3] mfd: simple-mfd-i2c: add default value

On Tue Jan 13, 2026 at 8:42 PM CST, Lee Jones wrote:
> On Thu, 08 Jan 2026, Troy Mitchell wrote:
>
>> The default value of the P1 sub-device depends on the value
>> of P1, so P1 should have a default value here.
>> 
>> Acked-by: Alex Elder <elder@...cstar.com>
>> Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
>> ---
>> Change log in v5:
>> - nothing
>> - Link to v4: https://lore.kernel.org/all/20251225-p1-kconfig-fix-v4-2-44b6728117c1@linux.spacemit.com/
>> 
>> Change log in v4:
>> - default m if ARCH_SPACEMIT instead of default ARCH_SPACEMIT
>> - Link to v3: https://lore.kernel.org/all/20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com/
>> ---
>>  drivers/mfd/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index aace5766b38aa5e46e32a8a7b42eea238159fbcf..c757bc365029dc794c658fc5b10084a0f29ac9b6 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1276,6 +1276,7 @@ config MFD_SPACEMIT_P1
>>  	depends on ARCH_SPACEMIT || COMPILE_TEST
>>  	depends on I2C
>>  	select MFD_SIMPLE_MFD_I2C
>> +	default m if ARCH_SPACEMIT
>>  	help
>>  	  This option supports the I2C-based SpacemiT P1 PMIC, which
>>  	  contains regulators, a power switch, GPIOs, an RTC, and more.
>
> I already applied v4.
Apologies, I missed this.
I will remove the patch in the next version. Thank you for your work.

                    - Troy