linux-kernel - Re: [PATCH v2 1/3] iio: adc: ad9467: include two's complement in default mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fe971bc-9ab0-42c6-a498-b67edb54dfb5@vaisala.com>
Date: Wed, 14 Jan 2026 09:41:48 +0200
From: Tomas Melin <tomas.melin@...sala.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>,
 Nuno Sa <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Andy Shevchenko <andy@...nel.org>,
 Olivier Moysan <olivier.moysan@...s.st.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] iio: adc: ad9467: include two's complement in
 default mode



On 13/01/2026 23:04, Andy Shevchenko wrote:
> On Tue, Jan 13, 2026 at 12:12:47PM +0000, Tomas Melin wrote:
>> All supported drivers currently implicitly use two's complement mode.
>> Make this clear by declaring two's complement in the default
>> output mode. Calibration mode uses offset binary, so change the output
>> mode only when running the calibration or other test mode.
> 
> ...
> 
>>  #include <linux/bitmap.h>
>>  #include <linux/bitops.h>
> 
> Side note: bitmap.h implies and guarantees all bit ops to be provided. No need
> to include bitops.h when bitmap.h is present.
> 
> ...
> 
>>  #define CHIPID_AD9652                   0xC1
>> +#define AD9652_DEF_OUTPUT_MODE		0x01
>>  #define AD9652_REG_VREF_MASK            0xC0
> 
> Another side note: The other definitions around (mistakenly) have been indented
> with spaces. You can see the problem in the diff.
I noticed this too but kept it out of this diff as not directly related.
Thanks for these remarks, keeping in mind for further updates.

BR,
Tomas



>