linux-kernel - Re: [PATCH] dt-bindings: Fix I2C bus node names in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114083317.GH30544@pendragon.ideasonboard.com>
Date: Wed, 14 Jan 2026 10:33:17 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Del Regno <angelogioacchino.delregno@...labora.com>,
	Tianping Fang <tianping.fang@...iatek.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix I2C bus node names in examples

On Wed, Jan 14, 2026 at 09:13:23AM +0100, Krzysztof Kozlowski wrote:
> I2C bus node names are expected to be just "i2c", if there is just one
> such node in given example.  Replace remaining bad examples with
> scripted:
> 
>   git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's/i2c[0-9] {/i2c {/'
> 
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> 
> Like Rob's commit 20a72af11f41 ("dt-bindings: Fix SPI and I2C bus node
> names in examples"). I checked also for SPI.
> 
> Rebased on Rob's tree - can you pick it up directly? Applies also on
> linux-next, so I do not expect conflicts.
> ---
>  .../bindings/embedded-controller/lenovo,yoga-c630-ec.yaml       | 2 +-
>  Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml   | 2 +-
>  Documentation/devicetree/bindings/usb/ite,it5205.yaml           | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> index a029b38e8dc0..c88fbd6ad940 100644
> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> @@ -50,7 +50,7 @@ additionalProperties: false
>  examples:
>    - |+
>      #include <dt-bindings/interrupt-controller/irq.h>
> -    i2c1 {
> +    i2c {
>          clock-frequency = <400000>;
>  
>          #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> index a89f740214f7..dffd23ca4839 100644
> --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> @@ -95,7 +95,7 @@ examples:
>      #include <dt-bindings/gpio/gpio.h>
>      #include <dt-bindings/media/video-interfaces.h>
>  
> -    i2c0 {
> +    i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> diff --git a/Documentation/devicetree/bindings/usb/ite,it5205.yaml b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> index 889710733de5..045fcb41ac4b 100644
> --- a/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> +++ b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> @@ -49,7 +49,7 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/interrupt-controller/irq.h>
> -    i2c2 {
> +    i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
>  

-- 
Regards,

Laurent Pinchart