linux-kernel - Re: [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWdb5FQpodBLZLHY@smile.fi.intel.com>
Date: Wed, 14 Jan 2026 11:03:33 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, arnd@...db.de, gregkh@...uxfoundation.org,
	srini@...nel.org, vkoul@...nel.org, neil.armstrong@...aro.org,
	sre@...nel.org, sboyd@...nel.org, krzk@...nel.org,
	dmitry.baryshkov@....qualcomm.com, quic_wcheng@...cinc.com,
	melody.olvera@....qualcomm.com, quic_nsekar@...cinc.com,
	ivo.ivanov.ivanov1@...il.com, abelvesa@...nel.org,
	luca.weiss@...rphone.com, konrad.dybcio@....qualcomm.com,
	mitltlatltl@...il.com, krishna.kurapati@....qualcomm.com,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com,
	Jonathan Cameron <jonathan.cameron@...wei.com>
Subject: Re: [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W
 wrapper functions

On Wed, Jan 14, 2026 at 09:39:57AM +0100, AngeloGioacchino Del Regno wrote:
> This driver doesn't need to add any register base address to any
> regmap call anymore since it was migrated to register as a SPMI
> subdevice with its own regmap reg_base, which makes the regmap
> API to automatically add such base address internally.
> 
> Since the iadc_{read,write,read_result}() functions now only do
> call regmap_{read,write,bulk_read}() and nothing else, simplify
> the driver by removing them and by calling regmap APIs directly.

...

>  {
>  	unsigned int count, retry;
>  	int ret;
> -	u8 sta1;
> +	u32 sta1;

Keep it in reversed xmas tree order.

>  	retry = interval_us / IADC_CONV_TIME_MIN_US;

-- 
With Best Regards,
Andy Shevchenko