linux-kernel - Re: [PATCH 1/3] scripts: generate_rust_analyzer: Add compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFO79IRELYPB.2V1XQTCGJL5DB@gmail.com>
Date: Wed, 14 Jan 2026 18:20:59 +0900
From: "Jesung Yang" <y.j3ms.n@...il.com>
To: "Tamir Duberstein" <tamird@...nel.org>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
 Krummrich" <dakr@...nel.org>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] scripts: generate_rust_analyzer: Add
 compiler_builtins -> core dep

On Thu Jul 24, 2025 at 12:39 AM KST, Tamir Duberstein wrote:
> Add a dependency edge from `compiler_builtins` to `core` to
> `scripts/generate_rust_analyzer.py` to match `rust/Makefile`. This has
> been incorrect since commit 8c4555ccc55c ("scripts: add
> `generate_rust_analyzer.py`")
>
> Signed-off-by: Tamir Duberstein <tamird@...nel.org>
> ---
>  scripts/generate_rust_analyzer.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 7c3ea2b55041..4639a756a932 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -83,7 +83,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
>      append_crate(
>          "compiler_builtins",
>          srctree / "rust" / "compiler_builtins.rs",
> -        [],
> +        ["core"],
>      )
>  
>      append_crate(

This looks good, but I think
`Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`")` and
`Cc: stable` tags should be specified.

For the change itself,

Reviewed-by: Jesung Yang <y.j3ms.n@...il.com>

Best regards,
Jesung