linux-kernel - Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWdgCblk91iJE4T2@hovoldconsulting.com>
Date: Wed, 14 Jan 2026 10:21:13 +0100
From: Johan Hovold <johan@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org,
	Vaibhav Hiremath <hvaibhav.linux@...il.com>,
	Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: greybus: arche: drop dangling Kconfig symbol

On Mon, Dec 29, 2025 at 10:27:04PM -0800, Randy Dunlap wrote:
> The Kconfig symbol USB_HSIC_USB3613 is not defined in the kernel source
> tree. Drop it since it unused.
>
> Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver")

As the commit message of that commit says this was done on purpose to
allow the driver to be compile tested without the out-of-tree driver
that never went upstream.

These days we have a USB hub driver that should probably be used
instead, but yeah, someone would need to do the rework.

And while referencing the commit is good, I'm not sure a Fixes tag is
warranted.

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

> --- linux-next-20251219.orig/drivers/staging/greybus/arche-platform.c
> +++ linux-next-20251219/drivers/staging/greybus/arche-platform.c
> @@ -23,14 +23,10 @@
>  #include <linux/of.h>
>  #include "arche_platform.h"
>  
> -#if IS_ENABLED(CONFIG_USB_HSIC_USB3613)
> -#include <linux/usb/usb3613.h>
> -#else
>  static inline int usb3613_hub_mode_ctrl(bool unused)
>  {
>  	return 0;
>  }
> -#endif
>  
>  #define WD_COLDBOOT_PULSE_WIDTH_MS	30
>  
> --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig
> +++ linux-next-20251219/drivers/staging/greybus/Kconfig
> @@ -206,7 +206,6 @@ endif	# GREYBUS_BRIDGED_PHY
>  
>  config GREYBUS_ARCHE
>  	tristate "Greybus Arche Platform driver"
> -	depends on USB_HSIC_USB3613 || COMPILE_TEST
>  	help
>  	  Select this option if you have an Arche device.

The above just seems to hide the fact that the driver currently cannot
be used.

Can you please at least add some kind of TODO comment to indicate that
the driver should be reworked to drop the dependency on the OOT driver?

And it's probably best to keep the depends on COMPILE_TEST until that
has been resolved. Perhaps also wrap usb3613_hub_mode_ctrl() in

	#ifdef CONFIG_COMPILE_TEST
	...
	#endif

Johan