linux-kernel - Re: [PATCH] sparc: don't reference obsolete termio struct for TC* constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <123e6a3a-6360-45cb-8eef-23b1660b9253@gaisler.com>
Date: Wed, 14 Jan 2026 10:20:35 +0100
From: Andreas Larsson <andreas@...sler.com>
To: Sam James <sam@...too.org>, "David S. Miller" <davem@...emloft.net>
Cc: Stian Halseth <stian@....no>, sparclinux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc: don't reference obsolete termio struct for TC*
 constants

On 2025-10-19 21:18, Sam James wrote:
> Sam James <sam@...too.org> writes:
>> Similar in nature to ab107276607af90b13a5994997e19b7b9731e251. glibc-2.42

Please refer to the referenced commit also with "commit", the SHA ID and
the oneline summary of the commit, like so:

commit ab107276607a ("powerpc: Fix struct termio related ioctl macros")

>> drops the legacy termio struct, but the ioctls.h header still defines some
>> TC* constants in terms of termio (via sizeof). Hardcode the values instead.
>>
>> This fixes building Python for example, which falls over like:
>>   ./Modules/termios.c:1119:16: error: invalid application of 'sizeof' to incomplete type 'struct termio'
>>
>> Link: https://bugs.gentoo.org/961769
>> Link: https://bugs.gentoo.org/962600
>> Co-authored-by: Stian Halseth <stian@....no>
>> Signed-off-by: Sam James <sam@...too.org>
>> ---
>> v3: Fix constants.
>> v2: Fix title.
>>
>>  arch/sparc/include/uapi/asm/ioctls.h | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Ping.
> 
>>
>> diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h
>> index 7fd2f5873c9e7..f26befbf690fb 100644
>> --- a/arch/sparc/include/uapi/asm/ioctls.h
>> +++ b/arch/sparc/include/uapi/asm/ioctls.h
>> @@ -5,10 +5,10 @@
>>  #include <asm/ioctl.h>
>>  
>>  /* Big T */
>> -#define TCGETA		_IOR('T', 1, struct termio)
>> -#define TCSETA		_IOW('T', 2, struct termio)
>> -#define TCSETAW		_IOW('T', 3, struct termio)
>> -#define TCSETAF		_IOW('T', 4, struct termio)
>> +#define TCGETA          0x40125401
>> +#define TCSETA          0x80125402
>> +#define TCSETAW         0x80125403
>> +#define TCSETAF         0x80125404
>>  #define TCSBRK		_IO('T', 5)
>>  #define TCXONC		_IO('T', 6)
>>  #define TCFLSH		_IO('T', 7)

Please also, like in commit ab107276607a ("powerpc: Fix struct termio
related ioctl macros"), add the previous definitions as comments in
order to be able to know in the future what these hard coded constants
really should correspond to.

Don't forget to make sure that the subject gets a [PATCH v4].

Thanks,
Andreas