linux-kernel - Re: [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware loading handling added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2c34f3e-9856-4811-a434-333930176162@web.de>
Date: Wed, 14 Jan 2026 10:45:13 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Bin Du <Bin.Du@....com>, Sultan Alsawaf <sultan@...neltoast.com>,
 Svetoslav Stoilov <Svetoslav.Stoilov@....com>, linux-media@...r.kernel.org,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Hans Verkuil <hverkuil@...all.nl>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Alexey Zagorodnikov <xglooom@...il.com>, Anson Tsao <anson.tsao@....com>,
 Benjamin Chan <benjamin.chan@....com>,
 Dominic Antony <Dominic.Antony@....com>,
 Gjorgji Rosikopulos <gjorgji.rosikopulos@....com>, King Li
 <king.li@....com>, Mario Limonciello <mario.limonciello@....com>,
 Phil Jawich <Phil.Jawich@....com>, Pratap Nirujogi
 <Pratap.Nirujogi@....com>, Richard Gong <richard.gong@....com>
Subject: Re: [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware
 loading handling added

…
> +++ b/drivers/media/platform/amd/isp4/isp4.c
…
> +void isp4_intr_enable(struct isp4_subdev *isp_subdev, u32 index, bool enable)
> +{
…

> +	spin_lock_irq(&isp_subdev->irq_lock);
> +	intr_en = isp4hw_rreg(isp_subdev->mmio, ISP_SYS_INT0_EN);
…
> +	isp4hw_wreg(isp_subdev->mmio, ISP_SYS_INT0_EN, intr_en);
> +	spin_unlock_irq(&isp_subdev->irq_lock);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irq)(&isp_subdev->irq_lock);”?
https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/spinlock.h#L571-L573

Regards,
Markus