linux-kernel - Re: [PATCH v8 00/10] SPMI: Implement sub-devices and migrate drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWdmBUO4U3izZCEa@smile.fi.intel.com>
Date: Wed, 14 Jan 2026 11:46:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, arnd@...db.de, gregkh@...uxfoundation.org,
	srini@...nel.org, vkoul@...nel.org, neil.armstrong@...aro.org,
	sre@...nel.org, sboyd@...nel.org, krzk@...nel.org,
	dmitry.baryshkov@....qualcomm.com, quic_wcheng@...cinc.com,
	melody.olvera@....qualcomm.com, quic_nsekar@...cinc.com,
	ivo.ivanov.ivanov1@...il.com, abelvesa@...nel.org,
	luca.weiss@...rphone.com, konrad.dybcio@....qualcomm.com,
	mitltlatltl@...il.com, krishna.kurapati@....qualcomm.com,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v8 00/10] SPMI: Implement sub-devices and migrate drivers

On Wed, Jan 14, 2026 at 11:43:38AM +0200, Andy Shevchenko wrote:
> On Wed, Jan 14, 2026 at 10:27:32AM +0100, AngeloGioacchino Del Regno wrote:
> > Changes in v8:
> >  - Renamed *res to *sub_sdev in devm_spmi_subdevice_remove() (Andy)
> >  - Changed kerneldoc wording to "error pointer" for function
> >    spmi_subdevice_alloc_and_add() (Andy)
> >  - Shuffled around some assignments in spmi_subdevice_alloc_and_add() (Andy)
> >  - Used device_property_read_u32() instead of of_property_read_u32()
> >    in all of the migrated drivers (Andy)
> >  - Changed .max_register field in all of the migrated drivers from
> >    0x100 to 0xff (Andy)
> >  - Kept `sta1` declaration in reversed xmas tree order in function
> >    iadc_poll_wait_eoc() of qcom-spmi-iadc.c (Andy)
> 
> Thanks, in principle I'm okay with this version, but it would be nice to have
> clarification on the max_register for sure (it doesn't prevent the series from
> being applied).

And FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

-- 
With Best Regards,
Andy Shevchenko