linux-kernel - Re: [PATCH can 0/5] can: usb: fix URB memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b5c8a8b-5832-4566-af45-dee6818fa44c@hartkopp.net>
Date: Wed, 14 Jan 2026 11:04:11 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol@...nel.org>, Wolfgang Grandegger
 <wg@...ndegger.com>, Sebastian Haas <haas@...-wuensche.com>,
 "David S. Miller" <davem@...emloft.net>,
 Frank Jungclaus <frank.jungclaus@....eu>, socketcan@....eu,
 Yasushi SHOJI <yashi@...cecubics.com>, Daniel Berglund <db@...ser.com>,
 Olivier Sobrie <olivier@...rie.be>,
 Remigiusz Kołłątaj <remigiusz.kollataj@...ica.com>,
 Bernd Krumboeck <b.krumboeck@...il.com>
Cc: kernel@...gutronix.de, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH can 0/5] can: usb: fix URB memory leaks

Hello Marc,

does this patch set need to be reworked due to this (AI) feedback from 
Jakub?

https://lore.kernel.org/linux-can/20260110223836.3890248-1-kuba@kernel.org/

The former/referenced PR has been pulled - so that specific patch might 
to be fixed again, so that usb_unanchor_urb(urb) is called after 
usb_submit_urb() ??

Best regards,
Oliver

On 10.01.26 18:28, Marc Kleine-Budde wrote:
> An URB memory leak [1] was recently fixed in the gs_usb driver. The driver
> did not take into account that completed URBs are no longer anchored,
> causing them to be lost during ifdown. The memory leak was fixed by
> re-anchoring the URBs in the URB completion callback.
> 
> Several USB CAN drivers are affected by the same error. Fix them
> accordingly.
> 
> [1] https://lore.kernel.org/all/20260109135311.576033-3-mkl@pengutronix.de/
> 
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> ---
> Marc Kleine-Budde (5):
>        can: ems_usb: ems_usb_read_bulk_callback(): fix URB memory leak
>        can: esd_usb: esd_usb_read_bulk_callback(): fix URB memory leak
>        can: kvaser_usb: kvaser_usb_read_bulk_callback(): fix URB memory leak
>        can: mcba_usb: mcba_usb_read_bulk_callback(): fix URB memory leak
>        can: usb_8dev: usb_8dev_read_bulk_callback(): fix URB memory leak
> 
>   drivers/net/can/usb/ems_usb.c                    | 2 ++
>   drivers/net/can/usb/esd_usb.c                    | 2 ++
>   drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 ++
>   drivers/net/can/usb/mcba_usb.c                   | 2 ++
>   drivers/net/can/usb/usb_8dev.c                   | 2 ++
>   5 files changed, 10 insertions(+)
> ---
> base-commit: 7470a7a63dc162f07c26dbf960e41ee1e248d80e
> change-id: 20260109-can_usb-fix-memory-leak-0d769e002393
> 
> Best regards,
> --
> Marc Kleine-Budde <mkl@...gutronix.de>
> 
>