linux-kernel - Re: [PATCH v2 3/6] staging: iio: ad9832: convert to devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWbyqKxgs4dV1fkx@debian-BULLSEYE-live-builder-AMD64>
Date: Tue, 13 Jan 2026 22:34:32 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Tomas Borquez <tomasborquez13@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 3/6] staging: iio: ad9832: convert to devm_mutex_init()

On 12/30, Tomas Borquez wrote:
> Use devm_mutex_init() for automatic resource cleanup when the device
> is removed or probe fails.
> 
> Signed-off-by: Tomas Borquez <tomasborquez13@...il.com>
> ---
>  drivers/staging/iio/frequency/ad9832.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index 35d8d51d5c2b..4bb203a67046 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -310,7 +310,9 @@ static int ad9832_probe(struct spi_device *spi)
>  		return dev_err_probe(dev, PTR_ERR(st->mclk), "failed to enable MCLK\n");
>  
>  	st->spi = spi;
> -	mutex_init(&st->lock);
> +	ret = devm_mutex_init(&spi->dev, &st->lock);
Can use just 'dev' instead of '&spi->dev' after the update from patch 1.

With that
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>

> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to initialize mutex\n");
>  
>  	indio_dev->name = spi_get_device_id(spi)->name;
>  	indio_dev->info = &ad9832_info;
> -- 
> 2.43.0
> 
>