linux-kernel - Re: [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWdso0jjRRdEpcAC@smile.fi.intel.com>
Date: Wed, 14 Jan 2026 12:14:59 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Petre Rodan <petre.rodan@...dimension.ro>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Andreas Klinger <ak@...klinger.de>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 05/13] iio: pressure: mprls0025pa: fix pressure
 calculation

On Wed, Jan 14, 2026 at 12:05:39PM +0200, Petre Rodan wrote:
> A sign change is needed for proper calculation of the pressure.
> 
> This is a minor fix since it only affects users that might have custom
> silicon from Honeywell that has honeywell,pmin-pascal != 0.
> 
> Also due to the fact that raw pressure values can not be lower
> than output_min (400k-3.3M) there is no need to calculate a decimal for
> the offset.

...

> int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)

>  	struct mpr_data *data;
>  	struct iio_dev *indio_dev;
>  	const char *triplet;
> -	s64 scale, offset;
>  	u32 func;
> +	s32 tmp;
> +	s64 odelta, pdelta;

Please, preserve reversed xmas tree order. And in general try to stick with that one.


-- 
With Best Regards,
Andy Shevchenko