linux-kernel - Re: [PATCH] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWjXB8BiPgKs6wlm@redhat.com>
Date: Thu, 15 Jan 2026 07:01:11 -0500
From: Brian Masney <bmasney@...hat.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: mturquette@...libre.com, sboyd@...nel.org, mturquette@...aro.org,
	pankaj.dev@...com, gabriel.fernandez@...com,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] clk: st: clkgen-pll: Fix a memory leak in
 clkgen_odf_register()

On Thu, Jan 15, 2026 at 12:55:24PM +0800, Haoxiang Li wrote:
> If clk_register_composite() fails, call kfree() to release
> div and gate.
> 
> Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Reviewed-by: Brian Masney <bmasney@...hat.com>

This patch looks good, however this patch belongs in a series with
your other work to clkgen-pll. I'm going to leave some comments on your
other patch that you posted to this driver.

Brian