lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260115121209.7060B42-hca@linux.ibm.com>
Date: Thu, 15 Jan 2026 13:12:09 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: "Kalyazin, Nikita" <kalyazin@...zon.co.uk>
Cc: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "kernel@...0n.name" <kernel@...0n.name>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "corbet@....net" <corbet@....net>, "maz@...nel.org" <maz@...nel.org>,
        "oupton@...nel.org" <oupton@...nel.org>,
        "joey.gouly@....com" <joey.gouly@....com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "yuzenghui@...wei.com" <yuzenghui@...wei.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "willy@...radead.org" <willy@...radead.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "david@...nel.org" <david@...nel.org>,
        "lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>,
        "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
        "vbabka@...e.cz" <vbabka@...e.cz>, "rppt@...nel.org" <rppt@...nel.org>,
        "surenb@...gle.com" <surenb@...gle.com>,
        "mhocko@...e.com" <mhocko@...e.com>, "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "martin.lau@...ux.dev" <martin.lau@...ux.dev>,
        "eddyz87@...il.com" <eddyz87@...il.com>,
        "song@...nel.org" <song@...nel.org>,
        "yonghong.song@...ux.dev" <yonghong.song@...ux.dev>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "sdf@...ichev.me" <sdf@...ichev.me>,
        "haoluo@...gle.com" <haoluo@...gle.com>,
        "jolsa@...nel.org" <jolsa@...nel.org>, "jgg@...pe.ca" <jgg@...pe.ca>,
        "jhubbard@...dia.com" <jhubbard@...dia.com>,
        "peterx@...hat.com" <peterx@...hat.com>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "pfalcato@...e.de" <pfalcato@...e.de>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "riel@...riel.com" <riel@...riel.com>,
        "ryan.roberts@....com" <ryan.roberts@....com>,
        "jgross@...e.com" <jgross@...e.com>,
        "yu-cheng.yu@...el.com" <yu-cheng.yu@...el.com>,
        "kas@...nel.org" <kas@...nel.org>, "coxu@...hat.com" <coxu@...hat.com>,
        "kevin.brodsky@....com" <kevin.brodsky@....com>,
        "ackerleytng@...gle.com" <ackerleytng@...gle.com>,
        "maobibo@...ngson.cn" <maobibo@...ngson.cn>,
        "prsampat@....com" <prsampat@....com>,
        "mlevitsk@...hat.com" <mlevitsk@...hat.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "jthoughton@...gle.com" <jthoughton@...gle.com>,
        "agordeev@...ux.ibm.com" <agordeev@...ux.ibm.com>,
        "alex@...ti.fr" <alex@...ti.fr>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>,
        "chenhuacai@...nel.org" <chenhuacai@...nel.org>,
        "dev.jain@....com" <dev.jain@....com>,
        "gor@...ux.ibm.com" <gor@...ux.ibm.com>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "pjw@...nel.org" <pjw@...nel.org>,
        "shijie@...amperecomputing.com" <shijie@...amperecomputing.com>,
        "svens@...ux.ibm.com" <svens@...ux.ibm.com>,
        "thuth@...hat.com" <thuth@...hat.com>,
        "wyihan@...gle.com" <wyihan@...gle.com>,
        "yang@...amperecomputing.com" <yang@...amperecomputing.com>,
        "vannapurve@...gle.com" <vannapurve@...gle.com>,
        "jackmanb@...gle.com" <jackmanb@...gle.com>,
        "aneesh.kumar@...nel.org" <aneesh.kumar@...nel.org>,
        "patrick.roy@...ux.dev" <patrick.roy@...ux.dev>,
        "Thomson, Jack" <jackabt@...zon.co.uk>,
        "Itazuri, Takahiro" <itazur@...zon.co.uk>,
        "Manwaring, Derek" <derekmn@...zon.com>,
        "Cali, Marco" <xmarcalx@...zon.co.uk>
Subject: Re: [PATCH v9 01/13] set_memory: add folio_{zap,restore}_direct_map
 helpers

On Wed, Jan 14, 2026 at 01:45:23PM +0000, Kalyazin, Nikita wrote:
> From: Nikita Kalyazin <kalyazin@...zon.com>
> 
> These allow guest_memfd to remove its memory from the direct map.
> Only implement them for architectures that have direct map.
> In folio_zap_direct_map(), flush TLB on architectures where
> set_direct_map_valid_noflush() does not flush it internally.

...

> diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c
> index d3ce04a4b248..df4a487b484d 100644
> --- a/arch/s390/mm/pageattr.c
> +++ b/arch/s390/mm/pageattr.c
> @@ -412,6 +412,24 @@ int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
>  	return __set_memory((unsigned long)page_to_virt(page), nr, flags);
>  }
>  
> +int folio_zap_direct_map(struct folio *folio)
> +{
> +	unsigned long addr = (unsigned long)folio_address(folio);
> +	int ret;
> +
> +	ret = set_direct_map_valid_noflush(folio_page(folio, 0),
> +					   folio_nr_pages(folio), false);
> +	flush_tlb_kernel_range(addr, addr + folio_size(folio));
> +
> +	return ret;
> +}

The instructions used in the s390 implementation of
set_direct_map_valid_noflush() do flush TLB entries.
The extra flush_tlb_kernel_range() is not required.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ