linux-kernel - Re: [PATCH v2] clk: st: clkgen-pll: Add cleaup in clkgen_c32_pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c72b1bfa-706d-4ef0-913e-38c42a49d182@web.de>
Date: Thu, 15 Jan 2026 13:27:46 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, linux-clk@...r.kernel.org,
 Brian Masney <bmasney@...hat.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: st: clkgen-pll: Add cleaup in
 clkgen_c32_pll_setup()

> In clkgen_c32_pll_setup(), there exists several leaks if errors ouccers.

                                                                  occur?


> Add iounmap() to free the memory allocated by clkgen_get_register_base().
> Add clk_unregister() and kfree to do the cleaup for clkgen_pll_register().

                                () calls?  cleanup?

Please avoid such typos at more places (including the summary phrase).


> Add a while to do the cleaup for clkgen_odf_register().
> Use distinct variable names for two register calls' return values.

I would find such sentences a bit nicer with a formatting for enumerations.

Regards,
Markus