linux-kernel - Re: [PATCH v2 12/23] mm/balloon_compaction: remove balloon_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3a04ba-6a33-44fa-8269-79317f961e08@lucifer.local>
Date: Thu, 15 Jan 2026 12:29:54 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linuxppc-dev@...ts.ozlabs.org,
        Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
        linux-doc@...r.kernel.org, virtualization@...ts.linux.dev,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Jonathan Corbet <corbet@....net>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jerrin Shaji George <jerrin.shaji-george@...adcom.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez <eperezma@...hat.com>,
        Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH v2 12/23] mm/balloon_compaction: remove
 balloon_page_push/pop()

On Thu, Jan 15, 2026 at 10:20:02AM +0100, David Hildenbrand (Red Hat) wrote:
> Let's remove these helpers as they are unused now.
>
> Signed-off-by: David Hildenbrand (Red Hat) <david@...nel.org>

OK exactly as asked in the last patch you do deliver :))

So good riddance to this and:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

> ---
>  include/linux/balloon_compaction.h | 30 ------------------------------
>  mm/balloon_compaction.c            |  5 ++---
>  2 files changed, 2 insertions(+), 33 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index 1452ea0635245..e5451cf1f6589 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -126,34 +126,4 @@ static inline void balloon_page_finalize(struct page *page)
>  		set_page_private(page, 0);
>  	/* PageOffline is sticky until the page is freed to the buddy. */
>  }
> -
> -/*
> - * balloon_page_push - insert a page into a page list.
> - * @head : pointer to list
> - * @page : page to be added
> - *
> - * Caller must ensure the page is private and protect the list.
> - */
> -static inline void balloon_page_push(struct list_head *pages, struct page *page)
> -{
> -	list_add(&page->lru, pages);
> -}
> -
> -/*
> - * balloon_page_pop - remove a page from a page list.
> - * @head : pointer to list
> - * @page : page to be added
> - *
> - * Caller must ensure the page is private and protect the list.
> - */
> -static inline struct page *balloon_page_pop(struct list_head *pages)
> -{
> -	struct page *page = list_first_entry_or_null(pages, struct page, lru);
> -
> -	if (!page)
> -		return NULL;
> -
> -	list_del(&page->lru);
> -	return page;
> -}
>  #endif /* _LINUX_BALLOON_COMPACTION_H */
> diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
> index c44e0b62203cc..90b2d61a593b7 100644
> --- a/mm/balloon_compaction.c
> +++ b/mm/balloon_compaction.c
> @@ -128,9 +128,8 @@ EXPORT_SYMBOL_GPL(balloon_page_alloc);
>   * Drivers must call this function to properly enqueue a new allocated balloon
>   * page before definitively removing the page from the guest system.
>   *
> - * Drivers must not call balloon_page_enqueue on pages that have been pushed to
> - * a list with balloon_page_push before removing them with balloon_page_pop. To
> - * enqueue a list of pages, use balloon_page_list_enqueue instead.
> + * Drivers must not enqueue pages while page->lru is still in
> + * use, and must not use page->lru until a page was unqueued again.
>   */
>  void balloon_page_enqueue(struct balloon_dev_info *b_dev_info,
>  			  struct page *page)
> --
> 2.52.0
>