linux-kernel - Re: [PATCH v2 17/23] mm/balloon_compaction: remove "extern" from functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00320516-c5c6-4192-9ce4-de63f6a6eaeb@lucifer.local>
Date: Thu, 15 Jan 2026 12:34:20 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linuxppc-dev@...ts.ozlabs.org,
        Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
        linux-doc@...r.kernel.org, virtualization@...ts.linux.dev,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Jonathan Corbet <corbet@....net>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jerrin Shaji George <jerrin.shaji-george@...adcom.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez <eperezma@...hat.com>,
        Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH v2 17/23] mm/balloon_compaction: remove "extern" from
 functions

On Thu, Jan 15, 2026 at 10:20:07AM +0100, David Hildenbrand (Red Hat) wrote:
> Adding "extern" to functions is frowned-upon. Let's just get rid of it
> for all functions here.

Yes, this is nice thanks!

>
> Signed-off-by: David Hildenbrand (Red Hat) <david@...nel.org>

LGTM so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

> ---
>  include/linux/balloon_compaction.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index eec8994056a44..7757e0e314fdb 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -59,14 +59,14 @@ struct balloon_dev_info {
>  	bool adjust_managed_page_count;
>  };
>
> -extern struct page *balloon_page_alloc(void);
> -extern void balloon_page_enqueue(struct balloon_dev_info *b_dev_info,
> -				 struct page *page);
> -extern struct page *balloon_page_dequeue(struct balloon_dev_info *b_dev_info);
> -extern size_t balloon_page_list_enqueue(struct balloon_dev_info *b_dev_info,
> -				      struct list_head *pages);
> -extern size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info,
> -				     struct list_head *pages, size_t n_req_pages);
> +struct page *balloon_page_alloc(void);
> +void balloon_page_enqueue(struct balloon_dev_info *b_dev_info,
> +		struct page *page);
> +struct page *balloon_page_dequeue(struct balloon_dev_info *b_dev_info);
> +size_t balloon_page_list_enqueue(struct balloon_dev_info *b_dev_info,
> +		struct list_head *pages);
> +size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info,
> +		struct list_head *pages, size_t n_req_pages);
>
>  static inline void balloon_devinfo_init(struct balloon_dev_info *balloon)
>  {
> --
> 2.52.0
>