linux-kernel - RE: [PATCH] phy: freescale: imx8qm-hsio: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8833F590D2D499143AEE29C58C8CA@AS8PR04MB8833.eurprd04.prod.outlook.com>
Date: Thu, 15 Jan 2026 01:52:26 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Thomas Richard <thomas.richard@...tlin.com>, Vinod Koul
	<vkoul@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	Frank Li <frank.li@....com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] phy: freescale: imx8qm-hsio: fix NULL pointer dereference

> -----Original Message-----
> From: Thomas Richard <thomas.richard@...tlin.com>
> Sent: 2026年1月15日 0:50
> To: Vinod Koul <vkoul@...nel.org>; Neil Armstrong
> <neil.armstrong@...aro.org>; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>; Frank Li
> <frank.li@....com>; Hongxing Zhu <hongxing.zhu@....com>
> Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>;
> linux-phy@...ts.infradead.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Thomas
> Richard <thomas.richard@...tlin.com>
> Subject: [PATCH] phy: freescale: imx8qm-hsio: fix NULL pointer dereference
> 
> [You don't often get email from thomas.richard@...tlin.com. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> During the probe the refclk_pad pointer is set to NULL if the
> 'fsl,refclk-pad-mode' property is not defined in the devicetree node. But in
> imx_hsio_configure_clk_pad() this pointer is unconditionally used which could
> result in a NULL pointer dereference. So check the pointer before to use it.
> 
> Fixes: 82c56b6dd24f ("phy: freescale: imx8qm-hsio: Add i.MX8QM HSIO PHY
> driver support")
> Signed-off-by: Thomas Richard <thomas.richard@...tlin.com>
Thanks for your patch.
Reviewed-by: Richard Zhu <hongxing.zhu@....com>

Best Regards
Richard Zhu
> ---
>  drivers/phy/freescale/phy-fsl-imx8qm-hsio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c
> b/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c
> index 977d21d753a5..279b8ac7822d 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c
> @@ -251,7 +251,7 @@ static void imx_hsio_configure_clk_pad(struct phy
> *phy)
>         struct imx_hsio_lane *lane = phy_get_drvdata(phy);
>         struct imx_hsio_priv *priv = lane->priv;
> 
> -       if (strncmp(priv->refclk_pad, "output", 6) == 0) {
> +       if (priv->refclk_pad && strncmp(priv->refclk_pad, "output", 6)
> + == 0) {
>                 pll = true;
>                 regmap_update_bits(priv->misc, HSIO_CTRL0,
>                                    HSIO_IOB_A_0_TXOE |
> HSIO_IOB_A_0_M1M0_MASK,
> 
> ---
> base-commit: c537e12daeecaecdcd322c56a5f70659d2de7bde
> change-id:
> 20260114-phy-fsl-imx8qm-hsio-fix-null-pointer-dereference-67b110635f77
> 
> Best regards,
> --
> Thomas Richard <thomas.richard@...tlin.com>