| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <109b8f7c-7a00-40e0-a48b-b3e4e30948b6@lucifer.local>
Date: Thu, 15 Jan 2026 13:45:37 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
linuxppc-dev@...ts.ozlabs.org,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
linux-doc@...r.kernel.org, virtualization@...ts.linux.dev,
Andrew Morton <akpm@...ux-foundation.org>,
Oscar Salvador <osalvador@...e.de>,
"Liam R. Howlett" <Liam.Howlett@...cle.com>,
Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
Jonathan Corbet <corbet@....net>,
Madhavan Srinivasan <maddy@...ux.ibm.com>,
Michael Ellerman <mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jerrin Shaji George <jerrin.shaji-george@...adcom.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Eugenio Pérez <eperezma@...hat.com>,
Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH v2 19/23] mm: rename balloon_compaction.(c|h) to
balloon.(c|h)
On Thu, Jan 15, 2026 at 10:20:09AM +0100, David Hildenbrand (Red Hat) wrote:
> Even without CONFIG_BALLOON_COMPACTION this infrastructure implements
> basic list and page management for a memory balloon.
>
> Signed-off-by: David Hildenbrand (Red Hat) <david@...nel.org>
Seems sensible so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---
> Documentation/core-api/mm-api.rst | 2 +-
> MAINTAINERS | 4 ++--
> arch/powerpc/platforms/pseries/cmm.c | 2 +-
> drivers/misc/vmw_balloon.c | 2 +-
> drivers/virtio/virtio_balloon.c | 2 +-
> include/linux/{balloon_compaction.h => balloon.h} | 11 +++++------
> mm/Makefile | 2 +-
> mm/{balloon_compaction.c => balloon.c} | 7 +++----
> 8 files changed, 15 insertions(+), 17 deletions(-)
> rename include/linux/{balloon_compaction.h => balloon.h} (92%)
> rename mm/{balloon_compaction.c => balloon.c} (98%)
>
> diff --git a/Documentation/core-api/mm-api.rst b/Documentation/core-api/mm-api.rst
> index 68193a4cfcf52..aabdd3cba58e8 100644
> --- a/Documentation/core-api/mm-api.rst
> +++ b/Documentation/core-api/mm-api.rst
> @@ -130,5 +130,5 @@ More Memory Management Functions
> .. kernel-doc:: mm/vmscan.c
> .. kernel-doc:: mm/memory_hotplug.c
> .. kernel-doc:: mm/mmu_notifier.c
> -.. kernel-doc:: mm/balloon_compaction.c
> +.. kernel-doc:: mm/balloon.c
> .. kernel-doc:: mm/huge_memory.c
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d044a58cbfe0..de8f89ca1149f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27536,9 +27536,9 @@ M: David Hildenbrand <david@...nel.org>
> L: virtualization@...ts.linux.dev
> S: Maintained
> F: drivers/virtio/virtio_balloon.c
> -F: include/linux/balloon_compaction.h
> +F: include/linux/balloon.h
> F: include/uapi/linux/virtio_balloon.h
> -F: mm/balloon_compaction.c
> +F: mm/balloon.c
>
> VIRTIO BLOCK AND SCSI DRIVERS
> M: "Michael S. Tsirkin" <mst@...hat.com>
> diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c
> index 7fd8b3d7e7637..7a3c4922685ab 100644
> --- a/arch/powerpc/platforms/pseries/cmm.c
> +++ b/arch/powerpc/platforms/pseries/cmm.c
> @@ -19,7 +19,7 @@
> #include <linux/stringify.h>
> #include <linux/swap.h>
> #include <linux/device.h>
> -#include <linux/balloon_compaction.h>
> +#include <linux/balloon.h>
> #include <asm/firmware.h>
> #include <asm/hvcall.h>
> #include <asm/mmu.h>
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index 53e9335b6718c..7fd3f709108c2 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -29,7 +29,7 @@
> #include <linux/rwsem.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
> -#include <linux/balloon_compaction.h>
> +#include <linux/balloon.h>
> #include <linux/vmw_vmci_defs.h>
> #include <linux/vmw_vmci_api.h>
> #include <asm/hypervisor.h>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 6ae00de78b61b..de8041c3285a1 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -13,7 +13,7 @@
> #include <linux/delay.h>
> #include <linux/slab.h>
> #include <linux/module.h>
> -#include <linux/balloon_compaction.h>
> +#include <linux/balloon.h>
> #include <linux/oom.h>
> #include <linux/wait.h>
> #include <linux/mm.h>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon.h
> similarity index 92%
> rename from include/linux/balloon_compaction.h
> rename to include/linux/balloon.h
> index 7757e0e314fdb..82585542300d6 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon.h
> @@ -1,8 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * include/linux/balloon_compaction.h
> - *
> - * Common interface definitions for making balloon pages movable by compaction.
> + * Common interface for implementing a memory balloon, including support
> + * for migration of pages inflated in a memory balloon.
> *
> * Balloon page migration makes use of the general "movable_ops page migration"
> * feature.
> @@ -35,8 +34,8 @@
> *
> * Copyright (C) 2012, Red Hat, Inc. Rafael Aquini <aquini@...hat.com>
> */
> -#ifndef _LINUX_BALLOON_COMPACTION_H
> -#define _LINUX_BALLOON_COMPACTION_H
> +#ifndef _LINUX_BALLOON_H
> +#define _LINUX_BALLOON_H
> #include <linux/pagemap.h>
> #include <linux/page-flags.h>
> #include <linux/migrate.h>
> @@ -75,4 +74,4 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon)
> balloon->migratepage = NULL;
> balloon->adjust_managed_page_count = false;
> }
> -#endif /* _LINUX_BALLOON_COMPACTION_H */
> +#endif /* _LINUX_BALLOON_H */
> diff --git a/mm/Makefile b/mm/Makefile
> index 9175f8cc65658..1e31e0a528dc1 100644
> --- a/mm/Makefile
> +++ b/mm/Makefile
> @@ -122,7 +122,7 @@ obj-$(CONFIG_CMA) += cma.o
> obj-$(CONFIG_NUMA) += numa.o
> obj-$(CONFIG_NUMA_MEMBLKS) += numa_memblks.o
> obj-$(CONFIG_NUMA_EMU) += numa_emulation.o
> -obj-$(CONFIG_MEMORY_BALLOON) += balloon_compaction.o
> +obj-$(CONFIG_MEMORY_BALLOON) += balloon.o
> obj-$(CONFIG_PAGE_EXTENSION) += page_ext.o
> obj-$(CONFIG_PAGE_TABLE_CHECK) += page_table_check.o
> obj-$(CONFIG_CMA_DEBUGFS) += cma_debug.o
> diff --git a/mm/balloon_compaction.c b/mm/balloon.c
> similarity index 98%
> rename from mm/balloon_compaction.c
> rename to mm/balloon.c
> index f41e4a179a431..5734dae81e318 100644
> --- a/mm/balloon_compaction.c
> +++ b/mm/balloon.c
> @@ -1,15 +1,14 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * mm/balloon_compaction.c
> - *
> - * Common interface for making balloon pages movable by compaction.
> + * Common interface for implementing a memory balloon, including support
> + * for migration of pages inflated in a memory balloon.
> *
> * Copyright (C) 2012, Red Hat, Inc. Rafael Aquini <aquini@...hat.com>
> */
> #include <linux/mm.h>
> #include <linux/slab.h>
> #include <linux/export.h>
> -#include <linux/balloon_compaction.h>
> +#include <linux/balloon.h>
>
> /*
> * Lock protecting the balloon_dev_info of all devices. We don't really
> --
> 2.52.0
>
Powered by blists - more mailing lists