linux-kernel - Re: [PATCH] media: mali-c55: core: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWj20s8j5Y6_Qdz3@zed>
Date: Thu, 15 Jan 2026 15:17:45 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: dan.scally@...asonboard.com, jacopo.mondi@...asonboard.com, 
	mchehab@...nel.org, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mali-c55: core: Remove redundant dev_err()

Hi Chen

On Thu, Jan 15, 2026 at 10:35:16AM +0800, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
>
> Remove the redundant dev_err() call to clean up the error path.
>

Indeed

Reviewed-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

Thanks
  j

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..ab8f7f6f3be1 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -868,7 +868,6 @@ static int mali_c55_probe(struct platform_device *pdev)
>  	mali_c55->irqnum = platform_get_irq(pdev, 0);
>  	if (mali_c55->irqnum < 0) {
>  		ret = mali_c55->irqnum;
> -		dev_err(dev, "failed to get interrupt\n");
>  		goto err_deinit_media_frameworks;
>  	}
>
> --
> 2.25.1
>