linux-kernel - Re: [PATCH v5 13/15] PCI: qcom: Drop the assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McOaOHAa7_A5YLdoRaRpF+mDgybt-4OTHGBBF462NebkA@mail.gmail.com>
Date: Thu, 15 Jan 2026 09:29:01 -0500
From: Bartosz Golaszewski <brgl@...nel.org>
To: manivannan.sadhasivam@....qualcomm.com
Cc: Manivannan Sadhasivam via B4 Relay <devnull+manivannan.sadhasivam.oss.qualcomm.com@...nel.org>, 
	linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Chen-Yu Tsai <wens@...nel.org>, 
	Brian Norris <briannorris@...omium.org>, 
	Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>, Niklas Cassel <cassel@...nel.org>, 
	Alex Elder <elder@...cstar.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, 
	Manivannan Sadhasivam <mani@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Bartosz Golaszewski <brgl@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Jingoo Han <jingoohan1@...il.com>
Subject: Re: [PATCH v5 13/15] PCI: qcom: Drop the assert_perst() callbacks

On Thu, 15 Jan 2026 08:29:05 +0100, Manivannan Sadhasivam via B4 Relay
<devnull+manivannan.sadhasivam.oss.qualcomm.com@...nel.org> said:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
>
> Previously, the pcie-qcom driver probed first, deasserted PERST#, enabled
> link training and scanned the bus. By the time the pwrctrl driver probe got
> called, link training was already enabled by the controller driver.
>
> Thus the pwrctrl drivers had to call the .assert_perst() callback, to
> assert PERST#, power on the needed resources, and then call the
> .assert_perst() callback to deassert PERST#.
>
> Now since all pwrctrl drivers and this controller driver have been
> converted to the new pwrctrl design where the pwrctrl drivers will first
> power on the devices before this driver deasserts PERST# and scan the bus.
> So there is no longer a need for .assert_perst() callback in this driver
> and in DWC core driver. Hence, drop them.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>