| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601152235.2MC3FUQp-lkp@intel.com>
Date: Thu, 15 Jan 2026 22:43:58 +0800
From: kernel test robot <lkp@...el.com>
To: Ciju Rajan K <crajank@...dia.com>, hdegoede@...hat.com,
ilpo.jarvinen@...ux.intel.com, tglx@...utronix.de
Cc: oe-kbuild-all@...ts.linux.dev, christophe.jaillet@...adoo.fr,
andriy.shevchenko@...ux.intel.com, vadimp@...dia.com,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
Ciju Rajan K <crajank@...dia.com>
Subject: Re: [PATCH platform-next v4 2/2] platform/mellanox: mlxreg-hotplug:
Enabling interrupt storm detection
Hi Ciju,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.19-rc5]
[cannot apply to tip/irq/core next-20260115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ciju-Rajan-K/kernel-irq-Add-generic-interrupt-storm-detection-mechanism/20260115-155438
base: linus/master
patch link: https://lore.kernel.org/r/20260115074909.245852-3-crajank%40nvidia.com
patch subject: [PATCH platform-next v4 2/2] platform/mellanox: mlxreg-hotplug: Enabling interrupt storm detection
config: x86_64-randconfig-161-20260115 (https://download.01.org/0day-ci/archive/20260115/202601152235.2MC3FUQp-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
smatch version: v0.5.0-8985-g2614ff1a
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260115/202601152235.2MC3FUQp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601152235.2MC3FUQp-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/platform/mellanox/mlxreg-hotplug.c:830:7: error: call to undeclared function 'irq_register_storm_detection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
830 | if (!irq_register_storm_detection(priv->irq, MLXREG_HOTPLUG_INTR_FREQ_HZ,
| ^
>> drivers/platform/mellanox/mlxreg-hotplug.c:847:2: error: call to undeclared function 'irq_unregister_storm_detection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
847 | irq_unregister_storm_detection(priv->irq);
| ^
2 errors generated.
vim +/irq_register_storm_detection +830 drivers/platform/mellanox/mlxreg-hotplug.c
762
763 static int mlxreg_hotplug_probe(struct platform_device *pdev)
764 {
765 struct mlxreg_core_hotplug_platform_data *pdata;
766 struct mlxreg_hotplug_priv_data *priv;
767 struct i2c_adapter *deferred_adap;
768 int err;
769
770 pdata = dev_get_platdata(&pdev->dev);
771 if (!pdata) {
772 dev_err(&pdev->dev, "Failed to get platform data.\n");
773 return -EINVAL;
774 }
775
776 /* Defer probing if the necessary adapter is not configured yet. */
777 deferred_adap = i2c_get_adapter(pdata->deferred_nr);
778 if (!deferred_adap)
779 return -EPROBE_DEFER;
780 i2c_put_adapter(deferred_adap);
781
782 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
783 if (!priv)
784 return -ENOMEM;
785
786 if (pdata->irq) {
787 priv->irq = pdata->irq;
788 } else {
789 priv->irq = platform_get_irq(pdev, 0);
790 if (priv->irq < 0)
791 return priv->irq;
792 }
793
794 priv->regmap = pdata->regmap;
795 priv->dev = pdev->dev.parent;
796 priv->pdev = pdev;
797
798 err = devm_request_irq(&pdev->dev, priv->irq,
799 mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
800 | IRQF_SHARED, "mlxreg-hotplug", priv);
801 if (err) {
802 dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
803 return err;
804 }
805
806 disable_irq(priv->irq);
807 spin_lock_init(&priv->lock);
808 INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
809 dev_set_drvdata(&pdev->dev, priv);
810
811 err = mlxreg_hotplug_attr_init(priv);
812 if (err) {
813 dev_err(&pdev->dev, "Failed to allocate attributes: %d\n",
814 err);
815 return err;
816 }
817
818 priv->hwmon = devm_hwmon_device_register_with_groups(&pdev->dev,
819 "mlxreg_hotplug", priv, priv->groups);
820 if (IS_ERR(priv->hwmon)) {
821 dev_err(&pdev->dev, "Failed to register hwmon device %ld\n",
822 PTR_ERR(priv->hwmon));
823 return PTR_ERR(priv->hwmon);
824 }
825
826 /* Perform initial interrupts setup. */
827 mlxreg_hotplug_set_irq(priv);
828
829 /* Register with generic interrupt storm detection */
> 830 if (!irq_register_storm_detection(priv->irq, MLXREG_HOTPLUG_INTR_FREQ_HZ,
831 mlxreg_hotplug_storm_handler, priv)) {
832 dev_warn(&pdev->dev, "Failed to register generic interrupt storm detection\n");
833 } else {
834 dev_info(&pdev->dev, "Registered generic storm detection for IRQ %d\n", priv->irq);
835 }
836
837 priv->after_probe = true;
838
839 return 0;
840 }
841
842 static void mlxreg_hotplug_remove(struct platform_device *pdev)
843 {
844 struct mlxreg_hotplug_priv_data *priv = dev_get_drvdata(&pdev->dev);
845
846 /* Unregister generic interrupt storm detection */
> 847 irq_unregister_storm_detection(priv->irq);
848
849 /* Clean interrupts setup. */
850 mlxreg_hotplug_unset_irq(priv);
851 devm_free_irq(&pdev->dev, priv->irq, priv);
852 }
853
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists