[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cece70b5-3ff6-492d-af90-9622361db012@amd.com>
Date: Thu, 15 Jan 2026 10:24:09 +0800
From: "Du, Bin" <bin.du@....com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl,
laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
prabhakar.mahadev-lad.rj@...renesas.com, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, sultan@...neltoast.com,
pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
mario.limonciello@....com, richard.gong@....com, anson.tsao@....com,
Svetoslav Stoilov <Svetoslav.Stoilov@....com>,
Alexey Zagorodnikov <xglooom@...il.com>
Subject: Re: [PATCH v7 3/7] media: platform: amd: Add isp4 fw and hw interface
On 1/15/2026 4:55 AM, Sakari Ailus wrote:
> Hi Bin,
>
> On Wed, Jan 07, 2026 at 04:44:11PM +0800, Du, Bin wrote:
>>>> +int isp4if_init(struct isp4_interface *ispif, struct device *dev, void __iomem *isp_mmio);
>>>
>>> Could you run
>>>
>>> $ ./scripts/checkpatch.pl --strict --max-line-length=80
>>>
>>> on the set, please?
>>>
>>
>> Oh, I will change --max-line-length in our checkpatch.pl from 100 to 80 and
>> fix all the violations. I used to think that the requirement has been
>> relaxed to 100 columns based on
>> https://www.phoronix.com/news/Linux-Kernel-Deprecates-80-Col
>
> The default checkpatch.pl warning has been changed but not the coding
> style. There are valid reasons why you might want to have longer lines,
> still checkpatch.pl not warning about those isn't one. :-)
>
Thank you for the clarification. I will adhere to the 80-character limit
as recommended by the kernel coding style.
--
Regards,
Bin
Powered by blists - more mailing lists