linux-kernel - Re: [PATCH v5] staging: octeon: Remove port status typedefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026011505-jokingly-clinic-c700@gregkh>
Date: Thu, 15 Jan 2026 16:31:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Karthikey Kadati <karthikey3608@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] staging: octeon: Remove port status typedefs

On Thu, Jan 15, 2026 at 08:53:27PM +0530, Karthikey Kadati wrote:
> Remove cvmx_pip_port_status_t and cvmx_pko_port_status_t typedefs and
> replace them with struct cvmx_pip_port_status and struct
> cvmx_pko_port_status to match Linux kernel coding style.
> 
> This also updates the MIPS architecture headers to name the structs so
> they can be referenced by the staging driver, resolving the build failure
> found in v2.
> 
> In v2, the anonymous struct definition in the header caused a compilation
> error when referenced in the driver. This patch names the structs in the
> headers and updates all usages to use the struct type directly, removing
> the typedefs as per coding style requirements.

This "V2" stuff doesn't need to be in the changelog text itself please.
It goes below the --- line so it doesn't show up in the changelog when
committed.

> 
> Signed-off-by: Karthikey Kadati <karthikey3608@...il.com>
> ---
> Changes in v4:
> - Completely removed typedefs (Greg KH). In v3, the struct was named
>   but the typedef keyword was retained. Now uses struct directly.
> - Clarified commit message regarding the robot report (it was a build failure
>   due to anonymous structs, fixed by naming overlap with typedef removal).
> Changes in v3:
> - Address robot feedback.
> Changes in v2:
> - Initial attempt.

Wasn't v1 an initial attempt?  :)



> ---
>  arch/mips/include/asm/octeon/cvmx-pip.h |  4 ++--
>  arch/mips/include/asm/octeon/cvmx-pko.h |  6 +++---
>  drivers/staging/octeon/ethernet.c       |  4 ++--
>  drivers/staging/octeon/octeon-stubs.h   | 12 ++++++------
>  4 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/asm/octeon/cvmx-pip.h
> index 01ca7267a2ba..1e107a9aa650 100644
> --- a/arch/mips/include/asm/octeon/cvmx-pip.h
> +++ b/arch/mips/include/asm/octeon/cvmx-pip.h
> @@ -236,7 +236,7 @@ typedef struct {
>  	uint64_t inb_octets;
>  	/* Number of packets with GMX/SPX/PCI errors received by PIP */
>  	uint16_t inb_errors;
> -} cvmx_pip_port_status_t;
> +};

You aren't really removing the typedef here, are you ?

Take some time, relax, and think this all through as to what you are
trying to do and how to do it.  Also be sure you are able to properly
build this code, as traditionally, this is a _VERY_ hard driver to
test-build.  It requires a cross-build to get right.

good luck!

greg k-h