linux-kernel - RE: [PATCH v14 14/34] PCI/AER: Report CXL or PCIe bus type in AER trace logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3d57c01a14749199b5c042b7f8e7b37@huawei.com>
Date: Thu, 15 Jan 2026 15:55:21 +0000
From: Mauro Carvalho Chehab <M.Chehab@...wei.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>, Terry Bowman
	<terry.bowman@....com>
CC: "dave@...olabs.net" <dave@...olabs.net>, "dave.jiang@...el.com"
	<dave.jiang@...el.com>, "alison.schofield@...el.com"
	<alison.schofield@...el.com>, "dan.j.williams@...el.com"
	<dan.j.williams@...el.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	Shiju Jose <shiju.jose@...wei.com>, "ming.li@...omail.com"
	<ming.li@...omail.com>, "mchehab+huawei@...nel.org"
	<mchehab+huawei@...nel.org>, "Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>, "rrichter@....com"
	<rrichter@....com>, "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
	"PradeepVineshReddy.Kodamati@....com" <PradeepVineshReddy.Kodamati@....com>,
	"lukas@...ner.de" <lukas@...ner.de>, "Benjamin.Cheatham@....com"
	<Benjamin.Cheatham@....com>, "sathyanarayanan.kuppuswamy@...ux.intel.com"
	<sathyanarayanan.kuppuswamy@...ux.intel.com>, "linux-cxl@...r.kernel.org"
	<linux-cxl@...r.kernel.org>, "vishal.l.verma@...el.com"
	<vishal.l.verma@...el.com>, "alucerop@....com" <alucerop@....com>,
	"ira.weiny@...el.com" <ira.weiny@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>
Subject: RE: [PATCH v14 14/34] PCI/AER: Report CXL or PCIe bus type in AER
 trace logging

> > The AER service driver and aer_event tracing currently log 'PCIe Bus Type'
> > for all errors. Update the driver and aer_event tracing to log 'CXL 
> > Bus Type' for CXL device errors.
> > 
> > This requires that AER can identify and distinguish between PCIe 
> > errors and CXL errors.
> > 
> > Introduce boolean 'is_cxl' to 'struct aer_err_info'. Add assignment in
> > aer_get_device_error_info() and pci_print_aer().
> > 
> > Update the aer_event trace routine to accept a bus type string parameter.
> > 
> > Signed-off-by: Terry Bowman <terry.bowman@....com>
> > Co-developed-by: Dan Williams <dan.j.williams@...el.com>
> > Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>
> I wonder if it is worth using __print_symbolic() etc and an integer storage rather than a string for in the tracepoints.
> However, not really that important to me as the strings are small anyway and there is no precedence of this in ras trace events.
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

It would be a lot better to pass integer values instead of strings. Right now, I'm working on a way
to have a CI to check if Kernel + rasdaemon is doing the right thing. The idea is to inject errors
on QEMU via QMP interface (main patches already there at QEMU tree).

By using integers, it sounds easier to veriy if everything was properly handled, as we can
ignore __print_symbolic at rasdaemon, picking the actual values directly.

Regards,
Mauro