linux-kernel - Re: [PATCH] media: renesas: vsp1: Fix NULL pointer deref on module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176849369817.1090220.1584761595893232111@ping.linuxembedded.co.uk>
Date: Thu, 15 Jan 2026 16:14:58 +0000
From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To: Hans Verkuil <hverkuil@...nel.org>, Jacopo Mondi <jacopo.mondi+renesas@...asonboard.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Subject: Re: [PATCH] media: renesas: vsp1: Fix NULL pointer deref on module unload

Quoting Tomi Valkeinen (2026-01-15 09:22:35)
> From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> 
> When unloading the module on gen 4, we hit a NULL pointer dereference.
> This is caused by the cleanup code calling vsp1_drm_cleanup() where it
> should be calling vsp1_vspx_cleanup().
> 
> Fix this by checking the IP version and calling the drm or vspx function
> accordingly, the same way as the init code does.

Looks reasonable to me:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> 
> Fixes: d06c1a9f348d ("media: vsp1: Add VSPX support")
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> ---
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_drv.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> index 6c64657fc4f3..30df9b36642d 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> @@ -240,8 +240,12 @@ static void vsp1_destroy_entities(struct vsp1_device *vsp1)
>                 media_device_unregister(&vsp1->media_dev);
>         media_device_cleanup(&vsp1->media_dev);
>  
> -       if (!vsp1->info->uapi)
> -               vsp1_drm_cleanup(vsp1);
> +       if (!vsp1->info->uapi) {
> +               if (vsp1->info->version == VI6_IP_VERSION_MODEL_VSPX_GEN4)
> +                       vsp1_vspx_cleanup(vsp1);
> +               else
> +                       vsp1_drm_cleanup(vsp1);
> +       }
>  }
>  
>  static int vsp1_create_entities(struct vsp1_device *vsp1)
> 
> ---
> base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
> change-id: 20260115-rcar-vsp-crash-fix-8d4871f0f39e
> 
> Best regards,
> -- 
> Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>