linux-kernel - Re: [PATCH v2 2/2] Input: ili210x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94402ad7-a28b-44db-b1b6-181c2d129cef@mailbox.org>
Date: Thu, 15 Jan 2026 17:19:40 +0100
From: Marek Vasut <marek.vasut@...lbox.org>
To: Frank Li <Frank.li@....com>
Cc: linux-input@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Job Noorman <job@...rman.info>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Input: ili210x - add support for polling mode

On 1/15/26 4:29 PM, Frank Li wrote:
> On Thu, Jan 15, 2026 at 03:34:59AM +0100, Marek Vasut wrote:
>> There are designs incorporating Ilitek ILI2xxx touch controller that
>> do not connect interrupt pin, for example Waveshare 13.3" DSI display.
>> To support such systems use polling mode for the input device when I2C
>> client does not have interrupt assigned to it.
>>
>> Factor out ili210x_firmware_update_noirq() to allow conditional scoped
>> guard around this code. The scoped guard has to be applied only in case
>> the IRQ line is connected, and not applied otherwise.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@...nel.org>
>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> Cc: Frank Li <Frank.Li@....com>
>> Cc: Job Noorman <job@...rman.info>
>> Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: devicetree@...r.kernel.org
>> Cc: linux-input@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-renesas-soc@...r.kernel.org
>> ---
>> V2: Test client->irq > 0 for IRQ presence
>> ---
>>   drivers/input/touchscreen/ili210x.c | 84 ++++++++++++++++++++---------
>>   1 file changed, 60 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
>> index fa38d70aded7b..0574f2e86580f 100644
>> --- a/drivers/input/touchscreen/ili210x.c
>> +++ b/drivers/input/touchscreen/ili210x.c
>> @@ -327,9 +327,8 @@ static bool ili210x_report_events(struct ili210x *priv, u8 *touchdata)
>>   	return contact;
>>   }
>>
> 
> ...
>>
>> -	error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> -					  IRQF_ONESHOT, client->name, priv);
>> -	if (error) {
>> -		dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> -			error);
>> -		return error;
>> +	input_set_drvdata(input, priv);
>> +
>> +	if (client->irq > 0) {
>> +		error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> +						  IRQF_ONESHOT, client->name, priv);
>> +		if (error) {
>> +			dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> +				error);
>> +			return error;
> 
> return dev_err_probe()
Fixed mostly in new patch part of V3 , thanks.