linux-kernel - Re: [PATCH v2 2/4] reset: Create subdirectory for SpacemiT drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f5a35fdc-9245-4be6-83a3-c1bfe86d30c9@riscstar.com>
Date: Thu, 15 Jan 2026 11:27:25 -0600
From: Alex Elder <elder@...cstar.com>
To: Guodong Xu <guodong@...cstar.com>, Philipp Zabel
 <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
 Haylen Chu <heylenay@....org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev
Subject: Re: [PATCH v2 2/4] reset: Create subdirectory for SpacemiT drivers

On 1/8/26 8:22 AM, Guodong Xu wrote:
> Create a dedicated subdirectory for SpacemiT reset drivers to allow
> for better organization as support for more SoCs is added.
> 
> Move the existing K1 reset driver into this new directory and rename
> it to reset-spacemit-k1.c.
> 
> Rename the Kconfig symbol to RESET_SPACEMIT_K1 and update its default
> from ARCH_SPACEMIT to SPACEMIT_K1_CCU. The reset driver depends on the
> clock driver to register reset devices as an auxiliary device, so the
> default should reflect this dependency.
> 
> Also sort the drivers/reset/Kconfig entries alphabetically.
> 
> Signed-off-by: Guodong Xu <guodong@...cstar.com>

At first I thought this was too many things for one patch, but
they're all pretty simple so I guess it's OK.

This looks good.

Reviewed-by: Alex Elder <elder@...cstar.com>

> ---
> v2: No change.
> ---
>   drivers/reset/Kconfig                                      | 12 ++----------
>   drivers/reset/Makefile                                     |  2 +-
>   drivers/reset/spacemit/Kconfig                             | 14 ++++++++++++++
>   drivers/reset/spacemit/Makefile                            |  3 +++
>   .../{reset-spacemit.c => spacemit/reset-spacemit-k1.c}     |  0
>   5 files changed, 20 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 6e5d6deffa7d367040b0b380b78ce02d775a3a63..b110f0fa7bb13eff63e1939e50a926cd0106db3f 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -299,15 +299,6 @@ config RESET_SOCFPGA
>   	  This enables the reset driver for the SoCFPGA ARMv7 platforms. This
>   	  driver gets initialized early during platform init calls.
>   
> -config RESET_SPACEMIT
> -	tristate "SpacemiT reset driver"
> -	depends on ARCH_SPACEMIT || COMPILE_TEST
> -	select AUXILIARY_BUS
> -	default ARCH_SPACEMIT
> -	help
> -	  This enables the reset controller driver for SpacemiT SoCs,
> -	  including the K1.
> -
>   config RESET_SUNPLUS
>   	bool "Sunplus SoCs Reset Driver" if COMPILE_TEST
>   	default ARCH_SUNPLUS
> @@ -406,9 +397,10 @@ config RESET_ZYNQMP
>   	  This enables the reset controller driver for Xilinx ZynqMP SoCs.
>   
>   source "drivers/reset/amlogic/Kconfig"
> +source "drivers/reset/hisilicon/Kconfig"
> +source "drivers/reset/spacemit/Kconfig"
>   source "drivers/reset/starfive/Kconfig"
>   source "drivers/reset/sti/Kconfig"
> -source "drivers/reset/hisilicon/Kconfig"
>   source "drivers/reset/tegra/Kconfig"
>   
>   endif
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 9c3e484dfd81a4f7b2f156a6226d5fa233600f9f..fc0cc99f8514cac161af59389ba1cbd5490209c8 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -2,6 +2,7 @@
>   obj-y += core.o
>   obj-y += amlogic/
>   obj-y += hisilicon/
> +obj-y += spacemit/
>   obj-y += starfive/
>   obj-y += sti/
>   obj-y += tegra/
> @@ -38,7 +39,6 @@ obj-$(CONFIG_RESET_RZV2H_USB2PHY) += reset-rzv2h-usb2phy.o
>   obj-$(CONFIG_RESET_SCMI) += reset-scmi.o
>   obj-$(CONFIG_RESET_SIMPLE) += reset-simple.o
>   obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
> -obj-$(CONFIG_RESET_SPACEMIT) += reset-spacemit.o
>   obj-$(CONFIG_RESET_SUNPLUS) += reset-sunplus.o
>   obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o
>   obj-$(CONFIG_RESET_TH1520) += reset-th1520.o
> diff --git a/drivers/reset/spacemit/Kconfig b/drivers/reset/spacemit/Kconfig
> new file mode 100644
> index 0000000000000000000000000000000000000000..552884e8b72afeb05cdb9b6565ad8e7fd32f990b
> --- /dev/null
> +++ b/drivers/reset/spacemit/Kconfig
> @@ -0,0 +1,14 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config RESET_SPACEMIT_K1
> +	tristate "SpacemiT K1 reset driver"
> +	depends on ARCH_SPACEMIT || COMPILE_TEST
> +	depends on SPACEMIT_K1_CCU
> +	select AUXILIARY_BUS
> +	default SPACEMIT_K1_CCU
> +	help
> +	  Support for reset controller in SpacemiT K1 SoC.
> +	  This driver works with the SpacemiT K1 clock controller
> +	  unit (CCU) driver to provide reset control functionality
> +	  for various peripherals and subsystems in the SoC.
> +
> diff --git a/drivers/reset/spacemit/Makefile b/drivers/reset/spacemit/Makefile
> new file mode 100644
> index 0000000000000000000000000000000000000000..de7e358c74fd7b0fac3ec2c18d985331af64fcbb
> --- /dev/null
> +++ b/drivers/reset/spacemit/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-$(CONFIG_RESET_SPACEMIT_K1)		+= reset-spacemit-k1.o
> +

Didn't git shout at you for having a blank line at the end of this file?

> diff --git a/drivers/reset/reset-spacemit.c b/drivers/reset/spacemit/reset-spacemit-k1.c
> similarity index 100%
> rename from drivers/reset/reset-spacemit.c
> rename to drivers/reset/spacemit/reset-spacemit-k1.c
>