linux-kernel - Re: [PATCH] cgroup/rstat: fix missing prototype warning for bpf_rstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+B7_oUcZDx2cs4sohAXNLy1qopkfsJsE-X158rfj2vhg@mail.gmail.com>
Date: Thu, 15 Jan 2026 10:45:58 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Ryota Sakamoto <sakamo.ryota@...il.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	Michal Koutný <mkoutny@...e.com>, 
	"open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] cgroup/rstat: fix missing prototype warning for bpf_rstat_flush()

On Thu, Jan 15, 2026 at 10:34 AM Ryota Sakamoto <sakamo.ryota@...il.com> wrote:
>
> Add the prototype to cgroup-internal.h to resolve the Sparse warning.
>
> The function bpf_rstat_flush() is defined as __weak and global in
> kernel/cgroup/rstat.c, but lack of prototype in header file causes warning
> with Sparse (C=1):
>
>   kernel/cgroup/rstat.c:342:22: warning: symbol 'bpf_rstat_flush' was not declared. Should it be static?

No. Ignore the warning. Sparse is incorrect.
We have hundreds of such bogus warnings. Do NOT attempt to send
more patches to "fix" them.

pw-bot: cr