linux-kernel - Re: [PATCH] thermal: debugfs: Use seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i4fyfYFXWKcNXnT7m67wfgpbjHdxCY0BjBoRPUorvEBw@mail.gmail.com>
Date: Thu, 15 Jan 2026 21:07:01 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sumeet Pawnikar <sumeet4linux@...il.com>
Cc: daniel.lezcano@...nel.org, rafael@...nel.org, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: debugfs: Use seq_puts() for constant string output

On Sat, Jan 10, 2026 at 7:39 PM Sumeet Pawnikar <sumeet4linux@...il.com> wrote:
>
> Replace seq_printf() with seq_puts() when outputting a constant string
> without format specifiers in the thermal mitigation debugfs interface.
> seq_puts() is more appropriate and efficient as it avoids unnecessary
> format string parsing overhead.
>
> No functional change.
>
> Signed-off-by: Sumeet Pawnikar <sumeet4linux@...il.com>
> ---
>  drivers/thermal/thermal_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c
> index 11d34f2a3d9f..11668f5b3c28 100644
> --- a/drivers/thermal/thermal_debugfs.c
> +++ b/drivers/thermal/thermal_debugfs.c
> @@ -807,7 +807,7 @@ static int tze_seq_show(struct seq_file *s, void *v)
>         seq_printf(s, ",-Mitigation at %llums, duration%c%llums, max. temp=%dm°C\n",
>                    ktime_to_ms(tze->timestamp), c, duration_ms, tze->max_temp);
>
> -       seq_printf(s, "| trip |     type | temp(m°C) | hyst(m°C) | duration(ms) |  avg(m°C) |  min(m°C) |\n");
> +       seq_puts(s, "| trip |     type | temp(m°C) | hyst(m°C) | duration(ms) |  avg(m°C) |  min(m°C) |\n");
>
>         for_each_trip_desc(tz, td) {
>                 const struct thermal_trip *trip = &td->trip;
> --

Applied as 6.20 material, thanks!