linux-kernel - Re: [PATCH 2/2] Input: ili210x - add support for polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de8a4c1f-8c60-4e3c-bba1-d9808468c8b1@mailbox.org>
Date: Thu, 15 Jan 2026 03:10:28 +0100
From: Marek Vasut <marek.vasut@...lbox.org>
To: Frank Li <Frank.li@....com>
Cc: linux-input@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Job Noorman <job@...rman.info>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: ili210x - add support for polling mode

On 1/13/26 5:41 PM, Frank Li wrote:

[...]

>> @@ -1003,12 +1027,24 @@ static int ili210x_i2c_probe(struct i2c_client *client)
>>   		return error;
>>   	}
>>
>> -	error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> -					  IRQF_ONESHOT, client->name, priv);
>> -	if (error) {
>> -		dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> -			error);
>> -		return error;
>> +	input_set_drvdata(input, priv);
>> +
>> +	if (client->irq) {
> 
> 0 is validated irq number
> 
> https://elixir.bootlin.com/linux/v6.19-rc4/source/drivers/base/platform.c#L284
> 
> if (irq < 0)
> 
> But it is strange that touch don't connect irq line althougth it works,
> touch generally is wakeup source of system.
Raspi is like that, they poll the touch controllers. It is unfortunate.