linux-kernel - Re: [PATCH v3 1/2] power: supply: Add macsmc-power driver for Apple Silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af3204c0-0492-4555-9a75-3716fa264ecd@kernel.org>
Date: Thu, 15 Jan 2026 22:00:33 +0100
From: Sven Peter <sven@...nel.org>
To: michael.reeves077@...il.com
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 Hector Martin <marcan@...can.st>, Lee Jones <lee@...nel.org>,
 Neal Gompa <neal@...pa.dev>, Janne Grunau <j@...nau.net>,
 Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH v3 1/2] power: supply: Add macsmc-power driver for Apple
 Silicon

Hi,


On 1/15/26 08:08, Michael Reeves via B4 Relay wrote:
> From: Michael Reeves <michael.reeves077@...il.com>
>
> This driver provides battery and AC status monitoring for Apple Silicon
> Macs via the SMC (System Management Controller). It supports
> reporting capacity, voltage, current, and charging status.
>
> Co-developed-by: Hector Martin <marcan@...can.st>
> Signed-off-by: Hector Martin <marcan@...can.st>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Signed-off-by: Michael Reeves <michael.reeves077@...il.com>
> ---
>   MAINTAINERS                         |   1 +
>   drivers/power/supply/Kconfig        |  11 +
>   drivers/power/supply/Makefile       |   1 +
>   drivers/power/supply/macsmc-power.c | 834 ++++++++++++++++++++++++++++++++++++
>   4 files changed, 847 insertions(+)
[...]
> +
> +static int macsmc_power_event(struct notifier_block *nb, unsigned long event, void *data)
> +{
> +	struct macsmc_power *power = container_of(nb, struct macsmc_power, nb);
> +
> +	/*
> +	 * SMC Event IDs are reverse-engineered.

Any chance you meant something else here? The event IDs aren't special, 
everything here is reverse-engineered ;)
No need to change this imho unless there's another reason for a v4 though:

Reviewed-by: Sven Peter <sven@...nel.org>


Sven