linux-kernel - Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecbb2dc3-7895-434d-b502-cbc82150fe01@kernel.org>
Date: Thu, 15 Jan 2026 22:01:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aman Kumar Pandey <aman.kumarpandey@....com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
 "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
 <robh@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "broonie@...nel.org" <broonie@...nel.org>, "lee@...nel.org"
 <lee@...nel.org>, Frank Li <frank.li@....com>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>,
 Vikash Bansal <vikash.bansal@....com>, Priyanka Jain
 <priyanka.jain@....com>,
 Shashank Rebbapragada <shashank.rebbapragada@....com>
Subject: Re: [EXT] Re: [PATCH v4 2/5] dt-bindings: i3c: Add NXP P3H2x4x
 i3c-hub support

On 15/01/2026 13:21, Aman Kumar Pandey wrote:
> 
> On Tue, Jan 13, 2026 at 01:45:26PM +0200, Aman Kumar Pandey wrote: 
>> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
>>> +cetree.org%2Fschemas%2Fmfd%2Fnxp%2Cp3h2840-i3c-
>> hub.yaml%23&data=05%7C
>>>
>> +02%7Caman.kumarpandey%40nxp.com%7C75a7d6f1f8b74fd3ac5808de5346
>> 3133%7C
>>>
>> +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C639039758104017624%7
>> CUnkno
>>>
>> +wn%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwM
>> CIsIlAiOiJX
>>>
>> +aW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Ze
>> GSgy3cF
>>> +whQbcO%2BserynVrrrqYGOIwBMgVjgdY25Lg%3D&reserved=0
>>
>> This is not a MFD device. Place it in appropriate place, e.g. i2c or i3c
>> controllers directory.
>>
> 
> Thanks for the review and the comment.
> 
> I would like to clarify why I modeled the P3H2840 as an MFD.

I do not see any model as MFD. You placed it in MFD directory and this
is what I contest.

Otherwise please point me to any hardware description what "MFD" is,
because for sure your I3C hub is not this:
https://en.wikipedia.org/wiki/MFD - scroll down to "Multifunction
device" in "Computing".

> While the primary function of the chip is an I3C hub, 

Wrap your emails so it will be possible to reply and read it.

So there you have your primary function.

> this device also contains a programmable regulator which is exposed externally and can be used to power downstream devices on the board, not only the internal hub logic. This regulator has:
> - Independent enable/disable control
> - Independent voltage configuration
> 
> From the board and hardware point of view, this block is not only a "hub-internal" power control, but a board-level power resource that other devices depend on. 
> hub logic and the regulator block have distinct roles and different Linux subsystems (I3C hub vs regulator framework), I modeled this as an MFD with two child devices.

Linux subsystems do not matter. We speak about bindings, not drivers.

You ignored some of my other comments. Your email is completely
unreadable, so answer is still NAK. Read my comments fully, fix your
email setup and then answer without all this messed quotes.

Best regards,
Krzysztof