linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2443b9d5-788c-4e26-ab1d-fb75853ad936@kernel.org>
Date: Thu, 15 Jan 2026 22:02:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Janani Sunil <jan.sun97@...il.com>, Janani Sunil <janani.sunil@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, gastmaier@...il.com
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007

On 15/01/2026 11:24, Janani Sunil wrote:
> Hi Krzysztof,
> 
> On 1/15/26 10:24, Krzysztof Kozlowski wrote:
>> On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote:
>>> Devicetree bindings for MAX22007 4-channel
>>> 12-bit DAC that drives a voltage or current
>>> output on each channel
>> What is happening with this patchset - why are you making somehow
>> unrelated, different, unexpected and incorrect changes like ones above?
>>
>> You are supposed to work with Git e.g. on dedicated branch, so you
>> clearly see what you did. Why doing such changes?
> 
> Apologies for the confusion- this was my mistake.
> 
> I picked up V1 of the patch by accident. I'll rework it to address the incorrect changes and will resend the corrected version.

How "picked"? You are supposed to have them in your git, on your
dedicated git branch for example. They cannot be "picked" or "unpicked"
because they are already there and you only add incremental changes
which you squash or commit amend. Really proficiency of Git is absolute
basic in kernel development.

Best regards,
Krzysztof