linux-kernel - Re: [PATCH v4 2/4] dt-bindings: soc: qcom: qcom,pmic-glink: Add Kaanapali and Glymur compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ph7gjuffgbxbn3k4oubdqsrogf4apxe3leowxdcu3l4wejownh@lx4s7zdah3u6>
Date: Thu, 15 Jan 2026 17:10:44 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
Cc: konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org, 
	abel.vesa@...aro.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: soc: qcom: qcom,pmic-glink: Add
 Kaanapali and Glymur compatibles

On Wed, Jan 14, 2026 at 01:17:57PM -0800, Anjelique Melendez wrote:
> Document the Kaanpali compatible string to have fallback on SM8550.
> Document the Glymur compatible string to have fallback on X1E80100.
> 
> Signed-off-by: Anjelique Melendez <anjelique.melendez@....qualcomm.com>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 012c5661115d..13503ae79a8d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -38,12 +38,18 @@ properties:
>            - const: qcom,pmic-glink
>        - items:
>            - enum:
> +              - qcom,kaanapali-pmic-glink
>                - qcom,milos-pmic-glink
>                - qcom,sm8650-pmic-glink
>                - qcom,sm8750-pmic-glink
>                - qcom,x1e80100-pmic-glink
>            - const: qcom,sm8550-pmic-glink
>            - const: qcom,pmic-glink

I'm sorry, Anjelique, taking another look at this I forgot about the
soccp-angle of the problem when we spoke.

Imagine when we add the next platform, using soccp and the other
properties of the Kaanapali pmic-glink solution.

This would require us to go:

compatible = "qcom,nextgen-pmic-glink", "qcom,kaanapali-pmic-glink", "qcom,sm8550-pmic-glink", "qcom,pmic-glink";

Because qcom,nextgen-pmic-glink isn't fully compatible with
qcom,sm8550-pmic-glink - as we see in pmic_glink.c.

> +      - items:
> +          - enum:
> +              - qcom,glymur-pmic-glink
> +          - const: qcom,x1e80100-pmic-glink
> +          - const: qcom,pmic-glink

And the same goes here.


So, while both of these are almost compatible with the previous mobile
and compute target, respectively, they aren't actually compatible.


The commit message of this commit needs to spell out how the features
differ in these two new targets in order for anyone to be able to say
whether this patch is makes sense or not.

Regards,
Bjorn

>  
>    '#address-cells':
>      const: 1
> -- 
> 2.34.1
>