linux-kernel - Re: [PATCH 2/2] zram: fixup read_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260115152553.ecaef2749017cf2e8f171390@linux-foundation.org>
Date: Thu, 15 Jan 2026 15:25:53 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, Chris Mason
 <clm@...a.com>
Subject: Re: [PATCH 2/2] zram: fixup read_block_state()

On Fri, 16 Jan 2026 07:54:25 +0900 Sergey Senozhatsky <senozhatsky@...omium.org> wrote:

> On (26/01/15 14:07), Andrew Morton wrote:
> > On Thu, 15 Jan 2026 12:30:06 +0900 Sergey Senozhatsky <senozhatsky@...omium.org> wrote:
> > 
> > > ac_time is now in seconds, do not use ktime_to_timespec64()
> > 
> > Please help me out here - which patch introduced the issue which Chris
> > found?
> 
> This one:
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-u32-for-entry-ac_time-tracking.patch

I figured that out when I fouf Chris's email ;)

> > > Reported-by: Chris Mason <clm@...a.com>
> > 
> > The Closes: link would be helpful.
> 
> I thought that for fixup patches that are still in your tree we
> don't need Closes: tags.  If you prefer to have them, it should
> be this email:
> http://lore.kernel.org/linux-kernel/20260114124522.1326519-1-clm@meta.com

Yep, got it thanks.

Closes: tags are helpful when reviewing, to see all the info.  Fixes:
tags aren't useful because the hashes are unstable and because the fix
is destined to become part of the thing which it fixes anyway.