linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ13v3S+u7fi2h1MUQ1QvFm6Ouz4TDrNwJq3fJvDmBf37h8LGQ@mail.gmail.com>
Date: Wed, 14 Jan 2026 22:38:22 -0600
From: Anirudh Srinivasan <anirudhsriniv@...il.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card

On Wed, Jan 14, 2026 at 7:03 PM Andrew Jeffery
<andrew@...econstruct.com.au> wrote:
>
> KODO is pretty consistent in the firmware update file name. KOMMANDO as
> the product identifier also seems reasonable, even if it only appears
> in FW_DESC in the latest release. KODO -> KOMMANDO seems reasonable.
>
> A brief bit of binwalking suggests it's an AMI MegaRAC implementation,
> and so I expect 'SPX-13' in FW_DESC refers to MegaRAC SP-X[1]. The
> significance of 'TB2' isn't yet unclear to me.

Yup. The screenshot in the PDF you linked looks a lot like the webui
on stock firmware. AMI has sources for a bunch of stuff ( "unmodified"
source tarballs and patches to apply on top of them manually) over
here [1].

>
> I'm not super concerned about the length of "asus,kommando-ipmi-
> expansion-card" - I'd prefer it over incorporating the 'kodo'
> contraction.

Understood.

>
> I guess it's still unclear whether 'kommando' is a (future) line of
> products or refers to the specific AST2600-based design. Perhaps we
> could solve a few problems with 'asus,kommando-ast2600' and including
> the phrase 'IPMI expansion card' in the binding description for
> something searchable.

I will make the compatible "asus,ast2600-kommando-ipmi-card" and have
the model name in the DT contain the phrase "IPMI expansion card" for
searchability. You mention about adding something to the binding
description (that'd end up being more than a one line change to the
bindings) but we could just have the DT model name have that
information.

I'll send out a second version of this series shortly. Thank you for
bearing with me on this. Naming things is hard.

[1] https://github.com/ami-megarac/OSSW-v13/tree/master/Core/

--
Regards
Anirudh Srinivasan