linux-kernel - Re: [PATCH 1/2] power: reset: Add QEMU virt-ctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWiGCY4aEF5dZOqY@google.com>
Date: Thu, 15 Jan 2026 14:15:37 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: Daniel Palmer <daniel@...f.com>
Cc: geert@...ux-m68k.org, sre@...nel.org, jserv@...s.ncku.edu.tw,
	eleanor15x@...il.com, linux-kernel@...r.kernel.org,
	linux-m68k@...ts.linux-m68k.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/2] power: reset: Add QEMU virt-ctrl driver

Hi Daniel,

On Wed, Jan 14, 2026 at 07:01:58PM +0900, Daniel Palmer wrote:
> Hi Kuan-Wei,
> 
> On Tue, 13 Jan 2026 at 03:27, Kuan-Wei Chiu <visitorckw@...il.com> wrote:
> >
> > Add a new driver for the 'virt-ctrl' device found on QEMU virt machines
> > (e.g. m68k). This device provides a simple interface for system reset
> > and power off [1].
> >
> > This driver registers a restart handler for system reboot and sets the
> > global pm_power_off callback for system shutdown. It is designed to be
> > generic and can be reused by other architectures utilizing this QEMU
> > device.
> >
> > Link: https://gitlab.com/qemu-project/qemu/-/blob/v10.2.0/hw/misc/virt_ctrl.c [1]
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@...il.com>
> 
> FWIW: I have a driver for this in my "m68k with devicetree" tree. As
> far as I could tell the virt_ctrl thing in QEMU might get more
> features aside from power control.
> So I made it a misc device instead.

Thanks for the note.
Just out of curious, are there currently specific plans to add
non-power features to virt_ctrl?

If new features are added, shouldn't they be exposed via separate
drivers in their respective subsystems, rather than consolidating
everything into a misc driver?

Regards,
Kuan-Wei